From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Date: Wed, 29 Jul 2015 13:53:52 +0200 (CEST) Message-ID: References: <1438157443-19447-1-git-send-email-t-kageyama@cp.jp.nec.com> <55B8BE39.6080500@hurleysoftware.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <55B8BE39.6080500@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org To: Peter Hurley Cc: Taichi Kageyama , "gregkh@linuxfoundation.org" , "jiang.liu@linux.intel.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "prarit@redhat.com" , Naoya Horiguchi List-Id: linux-serial@vger.kernel.org On Wed, 29 Jul 2015, Peter Hurley wrote: > On 07/29/2015 06:32 AM, Thomas Gleixner wrote: > > On Wed, 29 Jul 2015, Taichi Kageyama wrote: > >> - Keep interrupt disabled on the CPU which is used to detect > >> an interrupt during the timeout of autoconfig_irq(). > >> + Kick printk() on the CPU which detects interrupt > >> from a console serial port. > > > > This is wrong to begin with. How is that supposed to work on an UP > > machine? Not at all. > > > > So no, fix the code which has interrupts disabled accross autoprobing > > and do not try to apply bandaids somewhere else. > > Like printk() from some unrelated driver? If that's the cause for the wreckage then yes, we need a way to tell the printk code not to call into the driver until that initialization step is done. It's that simple. Thanks, tglx