From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Date: Thu, 30 Jul 2015 12:12:29 +0200 (CEST) Message-ID: References: <1438157443-19447-1-git-send-email-t-kageyama@cp.jp.nec.com> <55B8BE39.6080500@hurleysoftware.com> <55B8D26A.7000402@hurleysoftware.com> <55B980E6.70800@cp.jp.nec.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <55B980E6.70800@cp.jp.nec.com> Sender: linux-kernel-owner@vger.kernel.org To: Taichi Kageyama Cc: Peter Hurley , "gregkh@linuxfoundation.org" , "jiang.liu@linux.intel.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "prarit@redhat.com" , Naoya Horiguchi , Peter Zijlstra List-Id: linux-serial@vger.kernel.org On Thu, 30 Jul 2015, Taichi Kageyama wrote: > On 2015/07/29 22:35, Thomas Gleixner wrote: > I know your code is sample (console.h is required), > but it is conflict with [patch v2 1/3]. > I think serial8250_console_write should not touch ctrl reg during autoconfig_irq. > To resolve the real problem, I think keeping only [patch v2 1/3] is best(opt1). > What do you think? > > opt1. keep [patch v2 1/3] > + Don't touch other legacy drivers using autoprobe. > Each driver can use console_lock to fix this problem if it happens. No, we already know that autoprobing and console access can cause this, so we fix it at the core code and be done with it. Can you please test Peters patch and confirm that is solves it. Thanks, tglx