public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Cc: linux-serial@vger.kernel.org, Josh Cartwright <joshc@ni.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-rt-users@vger.kernel.org,
	Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling
Date: Sun, 13 Mar 2016 11:25:05 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1603131103020.3657@nanos> (raw)
In-Reply-To: <1457692476-19082-1-git-send-email-sean.nyekjaer@prevas.dk>

On Fri, 11 Mar 2016, Sean Nyekjaer wrote:

>  static irqreturn_t sc16is7xx_irq(int irq, void *dev_id)
>  {
>  	struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id;
> +	int i;
> +
> +	for (i = 0; i < s->devtype->nr_uart; ++i)
> +		disable_irq_nosync(s->p[i].port.irq);

Aside of the lack of a changelog. This is completely bogus. You disable the
same interrupt a gazillion of times. 

>  	queue_kthread_work(&s->kworker, &s->irq_work);

This driver should use a threaded interrupt instead of trying to emulate it
via dis/enable_irq and a worker thread.

Then you simply call c16is7xx_port_irq() right from the interrupt routine and
the core code deals with the interrupt mask/unmask automatically.

Thanks,

	tglx


  parent reply	other threads:[~2016-03-13 10:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 10:34 [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling Sean Nyekjaer
2016-03-11 10:36 ` Sean Nyekjær
2016-03-11 11:21   ` Sebastian Andrzej Siewior
2016-03-11 11:29     ` Sean Nyekjær
2016-03-11 11:33   ` Sean Nyekjær
2016-03-11 16:43 ` Greg Kroah-Hartman
2016-03-13 10:25 ` Thomas Gleixner [this message]
2016-03-14  6:21   ` Sean Nyekjær
2016-03-14  8:48     ` Thomas Gleixner
2016-03-14 23:13 ` Jakub Kiciński
  -- strict thread matches above, loose matches on Subject: below --
2016-03-13 19:05 Maarten Brock
2016-03-14  6:17 ` Sean Nyekjær

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1603131103020.3657@nanos \
    --to=tglx@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=joshc@ni.com \
    --cc=jringle@gridpoint.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sean.nyekjaer@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox