From: Linus Torvalds <torvalds@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dsaxena@plexity.net, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled
Date: Wed, 13 May 2009 07:58:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0905130755090.3343@localhost.localdomain> (raw)
In-Reply-To: <20090513094409.50c2409f@lxorguk.ukuu.org.uk>
On Wed, 13 May 2009, Alan Cox wrote:
>
> Then hard coding is no improvement either. It needs to restore the mode
> that was present at suspend.
Alan, you're missing the fact that this is a special-case for "this is the
console, and we're not suspending consoles AT ALL".
IOW, it was never suspended either, and it's a case that is known to be
fundamentally buggy (we're suspending all the PCI bridges, but not a
serial device that may be behind them!), but often work in _practice_
(because people don't use this thing for random serial devices, but for
things like integrated serial lines that don't lose power).
So we _could_ just save the mode, but that isn't really what this patch is
all about. The patch in question is about a total hack to avoid touching a
piece of hardware that we simply don't consider normal.
Linus
next prev parent reply other threads:[~2009-05-13 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 21:00 [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled Deepak Saxena
2009-05-12 22:00 ` Linus Torvalds
2009-05-13 0:18 ` Alan Cox
2009-05-13 0:28 ` Deepak Saxena
2009-05-13 8:44 ` Alan Cox
2009-05-13 14:58 ` Linus Torvalds [this message]
2009-05-13 15:35 ` Alan Cox
2009-05-13 18:04 ` Deepak Saxena
2009-05-13 18:46 ` Alan Cox
2009-05-18 18:24 ` Deepak Saxena
2009-05-18 19:07 ` Alan Cox
2009-05-13 1:01 ` Joe Perches
2009-05-13 0:34 ` Deepak Saxena
2009-05-12 22:08 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0905130755090.3343@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox