From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: longzhao@ambarella.com
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] serial: 8250_dw: add Ambarella CV75 quirks
Date: Fri, 14 Aug 2026 11:56:11 +0300 [thread overview]
Message-ID: <an7YKyVbe1YDtyL_@ashevche-desk.local> (raw)
In-Reply-To: <20260813-cv75-v3-c-v3-2-9352b3fd6026@ambarella.com>
On Thu, Aug 13, 2026 at 06:35:13PM +0800, Long Zhao via B4 Relay wrote:
> Add CV75 platform data with an ETOI IER mask and skip-set-rate so the
> DesignWare 8250 driver can drive the Ambarella UART for console use.
...
> + /* Keep variant-specific bits in the shadow across subsequent updates. */
This says what code is doing. Instead it must say "why?" the code is doing this.
> + up->ier |= d->pdata->ier_mask;
> + serial_port_out(p, UART_IER, up->ier);
...
In case there is an HW bug, where can we get the errata, please? (For a bare
minimum add a reference to the Errata document you give to the customers.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-14 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 10:35 [PATCH v3 0/2] Ambarella CV75: 8250_dw UART Long Zhao via B4 Relay
2026-08-13 10:35 ` [PATCH v3 1/2] dt-bindings: serial: snps-dw-apb-uart: add ambarella,cv75-uart Long Zhao via B4 Relay
2026-08-14 6:58 ` Linus Walleij
2026-08-13 10:35 ` [PATCH v3 2/2] serial: 8250_dw: add Ambarella CV75 quirks Long Zhao via B4 Relay
2026-08-14 6:59 ` Linus Walleij
2026-08-14 7:10 ` Long Zhao
2026-08-14 8:53 ` Andy Shevchenko
2026-08-14 8:56 ` Andy Shevchenko [this message]
2026-08-14 9:33 ` [EXT] " Long Zhao
2026-08-14 11:52 ` Andy Shevchenko
2026-08-14 12:10 ` Long Zhao
2026-08-14 12:16 ` Greg Kroah-Hartman
2026-08-14 12:31 ` Andy Shevchenko
2026-08-14 12:39 ` Long Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an7YKyVbe1YDtyL_@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=longzhao@ambarella.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox