From: Crescent Hsieh <crescentcy.hsieh@moxa.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] tty: moxa: remove driver.
Date: Wed, 5 Aug 2026 08:28:59 +0800 [thread overview]
Message-ID: <anKDyz8AEpyDpdeS@moxa-KabyLake-H> (raw)
In-Reply-To: <20260804-x-remove-moxa-v2-1-947c039b66e8@linuxfoundation.org>
On Tue, Aug 04, 2026 at 03:35:29PM +0200, Greg Kroah-Hartman wrote:
> This is a very old driver, and no known hardware is still around for it,
> and the company says they do not need it anymore, so let's remove it as
> the LLMs are starting to poke at it and find "interesting" things which
> will just waste everyone's time given it's not actually used.
>
> So let's drop it. If someone really needs it, it can come back in the
> future, in a more "modern" way, as the style here is very old...
The removal looks good to me.
Acked-by: Crescent Hsieh <crescentcy.hsieh@moxa.com>
With drivers/tty/moxa.c removed, the following device IDs in
include/linux/pci_ids.h would have no remaining users:
- PCI_DEVICE_ID_MOXA_CP204J
- PCI_DEVICE_ID_MOXA_C218
- PCI_DEVICE_ID_MOXA_C320
Would it make sense to remove them as part of this patch as well?
--
Thanks
Crescent Hsieh
next prev parent reply other threads:[~2026-08-05 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 13:35 [PATCH v2] tty: moxa: remove driver Greg Kroah-Hartman
2026-08-05 0:28 ` Crescent Hsieh [this message]
2026-08-05 4:59 ` Greg Kroah-Hartman
2026-08-05 6:35 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anKDyz8AEpyDpdeS@moxa-KabyLake-H \
--to=crescentcy.hsieh@moxa.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox