From: Johan Hovold <johan@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: fix ioctl hangup race
Date: Thu, 3 Sep 2026 19:06:17 +0200 [thread overview]
Message-ID: <apmpCSDZWCsGMtP1@hovoldconsulting.com> (raw)
In-Reply-To: <20260903164532.0B6FB1F000E9@smtp.kernel.org>
On Thu, Sep 03, 2026 at 04:45:31PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> New issues:
> - [High] Using a `break` statement inside `scoped_guard()` incorrectly
> exits the macro's internal loop instead of the intended outer `for
> (;;)` loop, leading to an infinite wait or severe latency.
Bah. Another reason to dislike guards.
> Pre-existing issues:
> - [High] The TIOCMIWAIT ioctl is still vulnerable to the hangup race
> because `uart_wait_modem_status()` accesses hardware registers via
> `uart_enable_ms()`, despite the commit message claiming otherwise.
I missed that call. Will revisit.
Johan
prev parent reply other threads:[~2026-09-03 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 16:34 [PATCH] serial: fix ioctl hangup race Johan Hovold
2026-09-03 16:45 ` sashiko-bot
2026-09-03 17:06 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apmpCSDZWCsGMtP1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox