Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: abort break signalling on hangup
Date: Thu, 3 Sep 2026 19:09:11 +0200	[thread overview]
Message-ID: <apmptysTEcbOEJLA@hovoldconsulting.com> (raw)
In-Reply-To: <20260903165004.B89561F000E9@smtp.kernel.org>

On Thu, Sep 03, 2026 at 04:50:04PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Missing hangup check before initiating the break state leaves
> the tty in a permanent break state if the port is already hung up.

As the commit message explains, drivers should already be clearing any
break state on shutdown (cf. closing a port after enabling break).

Johan

      reply	other threads:[~2026-09-03 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 16:37 [PATCH] tty: abort break signalling on hangup Johan Hovold
2026-09-03 16:50 ` sashiko-bot
2026-09-03 17:09   ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apmptysTEcbOEJLA@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox