From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Tate Whiteberg <whiteberg@arista.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250
Date: Mon, 28 Sep 2026 11:17:46 +0300 [thread overview]
Message-ID: <aroiqrAK1LWQ-nQp@ashevche-desk.local> (raw)
In-Reply-To: <20260927-tty-8250_mid-ns-import-v1-1-84d0482e1c5d@kernel.org>
On Sun, Sep 27, 2026 at 01:01:17AM +0200, Nathan Chancellor wrote:
> After commit 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty
> before setting termios"), modpost errors (or warning with
> CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=y):
>
> ERROR: modpost: drivers/tty/serial/8250/8250_mid.ko: module uses symbol 'serial8250_wait_for_xmitr' from namespace 'SERIAL_8250', but does not import it.
>
> Add the missing module namespace import to clear up the error/warning.
Oh, indeed, good catch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-09-28 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 23:01 [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250 Nathan Chancellor
2026-09-26 23:06 ` sashiko-bot
2026-09-28 8:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aroiqrAK1LWQ-nQp@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=whiteberg@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox