From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793892858; b=g1ZXPGKqKp3PvHsMqcddNW49oHmjkfU/BkJkNLhI6MsJNn5dqwNZj0szl8ErpRHBFcVa yrGiK5UsqgzJ4N9jCKsGpVIqVL+MVTD5ixC+m4JRrgWZImYYz0VhTY1how4d0E+FrUDia Hcaxntpcj8RkOY4l/ztLXcQewcEQMBKOUU5nMld/LC4eHqTMOYMZrRUmdXDaXLP3Mz7w7 qrcjT9dS6WHELugMIvBkJ14Dv2WiACQQ5NuQBIZdU+tcw0kkou+Wnhya+t+jFmjHgxvIq /3tKno2rh5+qyS83f5ckvOR/ug9ayYBhIZiMvz08QHOeCkcFZ+LUx8zWfLnx9mODODA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793892858; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=YNB1Wit5xYUO191VIQdW8ACPoY/mVp3oInWQ1K0PfQA=; b=cdh9RoAXiJVi0ef0/R+mxfzfSUCXcojqHNxotbYxs0dRsVw6XMFMvj4RkSlG3/iiAYZi xuWqoXoI8a5tAUf0msXAnUKvs+zvZkb8dnc5yYMNNli/Qib9XwmF1RqKEYgl5rFfuF/1G O2+bkl6+P4tVCiLxMVclfwn/4xfeAvA55JMA0E304esxd84y/o9IJKBBWOCtewHFRafhe pcG0VbLQSV8+69mS6VtvlXfRkGKtOkjeSAbhOYdfv51YFA3IGMSUzWrswPU6mJ8AyPZnG rUvtx5NiMqSD/FpU4ctkk8QWbbHjPCLIlobJuin8zx+nm6C20MZHnvsasNgJJgmqjaA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DvVbVPQc; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DCC606A31B; Thu, 5 Nov 2026 15:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DvVbVPQc Received: by smtp.kernel.org (Postfix) with ESMTPSA id C92D61F000C1; Thu, 5 Nov 2026 15:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793892857; bh=YNB1Wit5xYUO191VIQdW8ACPoY/mVp3oInWQ1K0PfQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=DvVbVPQc+2LQL+Wy17aVp5lNEAcdRdvX03FQSm3E+382FSh2QqDX+EPcpIBR7M1W7 v+57Kfl08brn4YYhpNdfIplE6yTwK2O0vgx+RW/H9Jky6OcBcL4opKPoLoCR+uelE2 SjQKeM/0l/KyNLFt7glHiPGGNbh5AozzmAwKv+y2u7+s0BZnC3OmC2y0T2a4xEdJot g25SKkeTr4hDDPiMcg/M0lFrCEpe41NxzODTK28SdLgucqCsG1RKMjkeXWPsNi+RNf 463H7bwuw1L01v2FwGULXf/JNollrCeo3gHgbIcojdvfX8GYEY+IXovf3gsr6rvKG/ K3Cyuwo5Uhabg== Date: Thu, 5 Nov 2026 16:34:15 +0100 From: Thierry Reding To: Krzysztof Kozlowski Cc: Andy Shevchenko , Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peter Griffin , Alim Akhtar , Laxman Dewangan , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Kartik Rajput , Fan Wu , Nicolai Buchwitz , Karl Mehltretter , Stefan =?utf-8?B?RMO2c2luZ2Vy?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..." , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/STM32 ARCHITECTURE" , vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Message-ID: References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> <2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org> X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ve7gdihn6fud63vw" Content-Disposition: inline In-Reply-To: <2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org> --ve7gdihn6fud63vw Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() MIME-Version: 1.0 On Thu, Nov 05, 2026 at 03:35:20PM +0100, Krzysztof Kozlowski wrote: > On 05/11/2026 15:17, Andy Shevchenko wrote: > >>> --- > >>> drivers/tty/serial/8250/8250_dma.c | 6 ++---- > >>> drivers/tty/serial/8250/8250_mtk.c | 3 +-- > >>> drivers/tty/serial/8250/8250_omap.c | 6 ++---- > >>> drivers/tty/serial/amba-pl011.c | 6 ++---- > >>> drivers/tty/serial/atmel_serial.c | 6 ++---- > >>> drivers/tty/serial/fsl_lpuart.c | 6 ++---- > >>> drivers/tty/serial/imx.c | 6 ++---- > >>> drivers/tty/serial/msm_serial.c | 6 ++---- > >>> drivers/tty/serial/mxs-auart.c | 6 ++---- > >>> drivers/tty/serial/pch_uart.c | 6 ++---- > >>> drivers/tty/serial/samsung_tty.c | 6 ++---- > >>> drivers/tty/serial/serial-tegra.c | 6 ++---- > >>> drivers/tty/serial/sh-sci.c | 9 +++------ > >>> drivers/tty/serial/sprd_serial.c | 3 +-- > >>> drivers/tty/serial/stm32-usart.c | 6 ++---- > >>> 15 files changed, 29 insertions(+), 58 deletions(-) > >> > >> Reviewed-by: Thierry Reding > >=20 > > Krzysztof, now look at this case. I would argue that this is even less = fit than > > # subpart(s) case, because it might imply anything. Again the problem i= s the > > bundle, and for such a case (when tons of independent changes are bundl= ed in > > the same stuff, *every* Rb tag has to be explained on what has been rev= iewed! >=20 > I think this case is obvious - Thierry reviewed this patch and gives Rb > tag, according to reviewer's statement of oversight. I don't see a > problem here or what is questionable. Correct. I looked at this whole thing and approve of it. If I review only parts of something at most I'll give an Acked-by. I don't think I've ever done partial reviews. I don't think you can reasonably do that because if you don't know what other parts of a patch are doing, how can you say that a specific hunk does what it's supposed to. Patches are an atomic set of changes, so I don't think it makes sense to review only parts of it. If you can't be bothered to look at the entirety, that's absolutely fine of course, but in that case don't provide a Reviewed-by. Or, I suppose, you do and then you bear the consequences of lending credibility to something that you haven't looked at or understood. Thierry --ve7gdihn6fud63vw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmrsofQACgkQ3SOs138+ s6H8Qw//cGBQstXaV/wKkkacAC3cWNFTL8+yZFsZNlz+TH8ENXGRirTUfKBfzoOF HtimCa5VVbkXs0qyUKXvTM/A5pF1Fq2cdpdO//TpEZnhwVfT6rv7KzsWuUyZVPNK DkLnxAMcceY7D6zjvtkqsLTUVikBBl+aXcI0ChSBy2Zug88hQpxxwJ/ux+kLs8xE WDuvRgyUhiJyTGdKru/8NhXKBOVAJnicYfBrndG9ZXG/4aIhpNNRXMQOelAfvhOT 3o6rWWLdXnTZapbimMPSVV8FTihEjQm7QszF0DUJha4h4c0O4gqgnP2FzUzj85u/ S8s2Mh4RRTlyx00NGsoZaoGTnoBhqnIYGXPd7cYgow4ClVf8j0H/dL6jfHwqXm6y +V9/F1fZcCWoaJp15qo3LQIfEkZuh6sFLJOCHP44fGS/c9y2fKniPUOKVgWUTvAr u/QrbShhYMlIVPV1vQOdgwum/0NQJacsHqfwJOEy9F73o3evJkdyhP/PBx1Za+Ho Gah9elyAWQ7TKJxB7yhxe9V8JfZyABe3VyDejZmjd7JRPshTe3gypOsRyAvU7gaX 0s2NAZsjTd97X6CDzlIrIGAy38HWlEa9F8GCeT+EcqlFpw8cuH3+15MUhkDxFHnf 2bYzFtnSkuEdOP+cgYjsukuXCuGEIvSWkZbAjHAuuQFu2PCn0l0= =lEfV -----END PGP SIGNATURE----- --ve7gdihn6fud63vw--