From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793893001; b=aOGAputtNR81+Qijl2BErvI9LHJvY9D4NoPrKvi8Ib631F0bqgaYs+QOFGofkxTf6XhP uFToFtjKowoK1pH/HtMn50/TB841jS3r8OHsvaG97JR/lthdzHoFU5lLfrjxs/bPtnrlH vkEXlzWdMlZWtuTBTunWKSyy5YpuqJPvcgSNogjmTaTKiJ5VvyLf/NxNmUz+MLaj/FzEC 3dfrR8wCG50kbE5vReD9DzsIvIoexVu5EIwz5seyntWTSx9RRy9U6H9d2v8zANivPTJyf 5VxK8MQAOAF1OUdO1K9rGk7Vp4rey2QCxQjINNV7NGuK6fZfvsIIRNH9eP7UkEriszQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793893001; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=WMIfUSC08BqgK169oF+WQophOR+gP8olx7dB7m3lVdI=; b=l1ges1sDQs99vnu83rn2Z/dk5BzwP7ioFkXPl7PIgNqKSDTNr/hHGqOYrB5JY5KGsUMy LQVEtED3SDIEDuuRoUh1YxfQ/kW7rR0WNaFyNvFDUrZEg3YJAryDZdu/I5EOLnhApeCSr Mg+7uPXv1VpWvCsb3sdZv9sCRsFsRZS/qnMuVm0G95b6pASFjuVT3BHFAzUftoacBBtwv XePrA7b1eowFYPJqQzkQ3gZv2hIuuM4XUdrmLXZ+YkRf5dICRQf7GTNJ6DHjJr4AStGkr 5rBh+vvjSZcD9fHdGCK3XMTB+OhE9Fhrfkwm3RlD+aCDm4TBgRGNYjJ/5PCuMZVG54g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GQ2UVcx0; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F776606A31B; Thu, 5 Nov 2026 15:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GQ2UVcx0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3617D1F000C1; Thu, 5 Nov 2026 15:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793893000; bh=WMIfUSC08BqgK169oF+WQophOR+gP8olx7dB7m3lVdI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GQ2UVcx0gaNOwo0yy9wftnb8YdlMK/DhNEwIT+Ja4l0mEunsi7pyo+Yoj+Ijw7oqf mUr8+4Y9IKNGF12cfn5mWrWn87XYuqmTMQJphnw2OCQ1WjYneGTAZvps6xLlNfO5oQ oSJHx8/355u1AZtd58DBfy/xtRnTeZ+VZojz2v6C5itcJZdiGLR/hsGTAG0ZSV9VY9 n8FER9NZsV8jYHgeaY4da3lu7SKNrw57S8PTG90MNhkl296SICCgdGoTg13reFYICw zfTvJI58o4+DE8ClCZFFcs1HAxxT/4YOpd2sEFGXy+nwq3X6z+W1BgMZrSWmNG4Y7s B7xxjbNedfKbQ== Date: Thu, 5 Nov 2026 16:36:38 +0100 From: Thierry Reding To: Andy Shevchenko Cc: Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laxman Dewangan , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Kartik Rajput , Fan Wu , Nicolai Buchwitz , Karl Mehltretter , Stefan =?utf-8?B?RMO2c2luZ2Vy?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..." , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/STM32 ARCHITECTURE" , vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Message-ID: References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2ahiyus6jckmdxu2" Content-Disposition: inline In-Reply-To: --2ahiyus6jckmdxu2 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() MIME-Version: 1.0 On Thu, Nov 05, 2026 at 04:17:53PM +0200, Andy Shevchenko wrote: > On Thu, Nov 05, 2026 at 01:28:46PM +0100, Thierry Reding wrote: > > On Mon, Nov 02, 2026 at 12:54:48PM -0500, Frank.Li@oss.nxp.com wrote: > > >=20 > > > Replace open-coded assignments to callback and callback_param fields > > > of struct dma_async_tx_descriptor with calls to the > > > dmaengine_desc_set_callback() helper across serial drivers. > > >=20 > > > No functional change intended. Prepare to make struct > > > dma_async_tx_descriptor private to the DMA engine. > > >=20 > > > Signed-off-by: Frank Li > > > --- > > > drivers/tty/serial/8250/8250_dma.c | 6 ++---- > > > drivers/tty/serial/8250/8250_mtk.c | 3 +-- > > > drivers/tty/serial/8250/8250_omap.c | 6 ++---- > > > drivers/tty/serial/amba-pl011.c | 6 ++---- > > > drivers/tty/serial/atmel_serial.c | 6 ++---- > > > drivers/tty/serial/fsl_lpuart.c | 6 ++---- > > > drivers/tty/serial/imx.c | 6 ++---- > > > drivers/tty/serial/msm_serial.c | 6 ++---- > > > drivers/tty/serial/mxs-auart.c | 6 ++---- > > > drivers/tty/serial/pch_uart.c | 6 ++---- > > > drivers/tty/serial/samsung_tty.c | 6 ++---- > > > drivers/tty/serial/serial-tegra.c | 6 ++---- > > > drivers/tty/serial/sh-sci.c | 9 +++------ > > > drivers/tty/serial/sprd_serial.c | 3 +-- > > > drivers/tty/serial/stm32-usart.c | 6 ++---- > > > 15 files changed, 29 insertions(+), 58 deletions(-) > >=20 > > Reviewed-by: Thierry Reding >=20 > Krzysztof, now look at this case. I would argue that this is even less fi= t than > # subpart(s) case, because it might imply anything. Again the problem is = the > bundle, and for such a case (when tons of independent changes are bundled= in > the same stuff, *every* Rb tag has to be explained on what has been revie= wed! It may be a bit subtle, but the placement of the tag indicates that it applies to the entirety of the changes. I didn't crop the list of changed files, nor did I omit the summary. That bit of meta-data obviously isn't picked up into the tag line, but I think the default meaning of Reviewed-by is that it applies to the entire thing. Thierry --2ahiyus6jckmdxu2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmrsooYACgkQ3SOs138+ s6HsEBAAvgrbYKAHxYaotfiffEkaiu5bekj96h6z+cilejnIbjAQULN3YB/vJgMw 989E+Tc9xOUp2VZUOGlEURoAZlx2VASTX17Z9qMdAMBvAU9JaaRRR3lgg3DBe9P8 nesEI+jXi55+OB8tZg5FthLgQGbxy/lM0Nqch6aZbmT6leB70s5h6lYrHeoafCtw 3qy76KmxowG5jx/CIQHQhUhC5jMsTFlqoX/6YoC2ps0L2dinYqON9TEhN+ljs0hp kYmyPE4g1QaXGk2sUrrCM18iLOxjNtJwNspmndfkUP8T1v6qexGmSJXeQMAF6Hsx Mb47ov4M1dpeFP4TcXghlmJdCbDQyO6Z+SDMzMOO33UdOkC+MrSb8P8yuN4QD909 Dw/3qIapRxlrxhIkmd+dihmne+1irCgEMuTqpJful+lMYOWQ2yESoE+G9u9fJHDI wL7sTTrtCEMAl2oaO6xtAmaV6/FHFgCG8vCMM1QVg6zuSGk3mTW3qQbRO5ginzwk tAxKdIbWeU0RQoXINwh24JoAQs+rswnGgFUBvl+XZpNgnp7NOs2DrvC1uueuxtvB 1s57F8cZLIwxAMhmnBNKuTiu8YGNEwNGVQpoCBDvvdTohhssdav1DaP462lhmVfh aLHhfjTv/1wqXk95lqVM51sm3ytRti+1p0zjyqZN0Hm+p3vnZX8= =tFls -----END PGP SIGNATURE----- --2ahiyus6jckmdxu2--