From: Jiri Slaby <jirislaby@kernel.org>
To: "Starke, Daniel" <daniel.starke@siemens.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config()
Date: Mon, 9 May 2022 13:13:19 +0200 [thread overview]
Message-ID: <b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org> (raw)
In-Reply-To: <DB9PR10MB588149B7E9A31D3476762776E0C69@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
On 09. 05. 22, 13:03, Starke, Daniel wrote:
>>> static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
>>> {
>>> + int ret = 0;
>>
>> Why is the initialization needed? You can as well declare the variable only inside the if below.
>
> You are right, this was unneeded. But this patch was already included in
> the tty-linus branch. Shall I resubmit it nevertheless?
In that case, you can only send a fixup patch...
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-05-09 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 11:03 [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config() Starke, Daniel
2022-05-09 11:13 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-04 8:17 [PATCH 1/3] tty: n_gsm: fix buffer over-read in gsm_dlci_data() D. Starke
2022-05-04 8:17 ` [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config() D. Starke
2022-05-09 10:28 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org \
--to=jirislaby@kernel.org \
--cc=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).