Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: sashiko-reviews@lists.linux.dev, Fil Dunsky <filipp.dunsky@gmail.com>
Cc: linux-serial@vger.kernel.org, robh@kernel.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH RFC v3 07/10] tty: serial: Add Cortina UART driver
Date: Mon, 12 Oct 2026 09:13:02 +0200	[thread overview]
Message-ID: <b48bdddf-2218-4164-8a76-e9cfa2802111@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-167778@kernel.org>

On 12. 10. 26, 9:10, sashiko-bot@kernel.org wrote:
>> +static void cortina_uart_set_termios(struct uart_port *port,
>> +				     struct ktermios *termios,
>> +				     const struct ktermios *old)
>> +{
> [ ... ]
>> +	uart_port_lock_irqsave(port, &flags);

Seeing this, why not to use guard()?

>> +
>> +	port->ignore_status_mask = 0;
>> +	if (!(termios->c_cflag & CREAD))
>> +		port->ignore_status_mask |= CORTINA_UART_RXDAT_VALID;
>> +
>> +	uart_update_timeout(port, termios->c_cflag, baud);

-- 
js
suse labs

  reply	other threads:[~2026-10-12  7:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  6:58 [PATCH RFC v3 00/10] ARM: Add support for Cortina Systems CS75xx and Securifi Almond+ Fil Dunsky via B4 Relay
2026-10-12  6:58 ` [PATCH RFC v3 01/10] dt-bindings: vendor-prefixes: Add Securifi Fil Dunsky via B4 Relay
2026-10-12  6:59   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 02/10] dt-bindings: arm: Add Cortina Systems CS7542 and Securifi Almond+ Fil Dunsky via B4 Relay
2026-10-12  7:00   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 03/10] dt-bindings: arm: cpus: Add Cortina Systems CS7542 enable method Fil Dunsky via B4 Relay
2026-10-12  7:01   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 04/10] ARM: goldengate: Add support for the CS75xx SoC family Fil Dunsky via B4 Relay
2026-10-12  7:07   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 05/10] ARM: debug: Add Cortina Systems CS75xx UART0 support Fil Dunsky via B4 Relay
2026-10-12  7:05   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 06/10] dt-bindings: serial: Add Cortina Systems CS7542 UART Fil Dunsky via B4 Relay
2026-10-12  7:00   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 07/10] tty: serial: Add Cortina UART driver Fil Dunsky via B4 Relay
2026-10-12  7:10   ` sashiko-bot
2026-10-12  7:13     ` Jiri Slaby [this message]
2026-10-12  7:24       ` Fil Dunsky
2026-10-12  6:58 ` [PATCH RFC v3 08/10] ARM: dts: cortina: Add CS7542 SoC and Securifi Almond+ board Fil Dunsky via B4 Relay
2026-10-12  7:04   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 09/10] ARM: multi_v7_defconfig: Enable Cortina Systems CS75xx support Fil Dunsky via B4 Relay
2026-10-12  7:01   ` sashiko-bot
2026-10-12  6:58 ` [PATCH RFC v3 10/10] MAINTAINERS: Add entry for Cortina Systems CS75xx Fil Dunsky via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b48bdddf-2218-4164-8a76-e9cfa2802111@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=filipp.dunsky@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox