From: Jiri Slaby <jirislaby@kernel.org>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
gregkh@linuxfoundation.org, kgugala@antmicro.com,
mholenko@antmicro.com, joel@jms.id.au,
david.abdurachmanov@gmail.com, florent@enjoy-digital.fr,
geert@linux-m68k.org, ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH v5 09/14] serial: liteuart: fix rx loop variable types
Date: Wed, 23 Nov 2022 06:39:39 +0100 [thread overview]
Message-ID: <b5888b92-ed6c-98c7-0d38-982a31e10e4f@kernel.org> (raw)
In-Reply-To: <Y305gZnFSaUBtCRa@errol.ini.cmu.edu>
On 22. 11. 22, 22:05, Gabriel L. Somlo wrote:
> So, looking at what uart_insert_char() does, I could simply do this
> instead:
>
> while(!litex_read8(membase + OFF_RXEMPTY) {
> ...
> /* LiteUART does not provide overrun bits */
> if (!(uart_handle_sysrq_char(port, ch) ||
> tty_insert_flip_char(&port->state->port, ch, TTY_NORMAL)))
> ++port->icount.buf_overrun;
>
> That is, `tty_insert_flip_char() is the portion of `uart_insert_char()`
> that actually gets executed if status is 1 and overrun is 0...
>
> I'm not quite confident about whether this is an improvement in legibility
> and/or code quality,
It's not :). Keep the uart_ helper.
--
js
suse labs
next prev parent reply other threads:[~2022-11-23 5:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 14:54 [PATCH v5 00/14] serial: liteuart: add IRQ support Gabriel Somlo
2022-11-18 14:54 ` [PATCH v5 01/14] serial: liteuart: use KBUILD_MODNAME as driver name Gabriel Somlo
2022-11-21 9:45 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 02/14] serial: liteuart: use bit number macros Gabriel Somlo
2022-11-21 9:45 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 03/14] serial: liteuart: remove unused uart_ops stubs Gabriel Somlo
2022-11-21 9:49 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 04/14] serial: liteuart: don't set unused port fields Gabriel Somlo
2022-11-21 9:53 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 05/14] serial: liteuart: minor style fix in liteuart_init() Gabriel Somlo
2022-11-21 9:53 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 06/14] serial: liteuart: move tty_flip_buffer_push() out of rx loop Gabriel Somlo
2022-11-21 9:55 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 07/14] serial: liteuart: rx loop should only ack rx events Gabriel Somlo
2022-11-18 14:55 ` [PATCH v5 08/14] serial: liteuart: simplify passing of uart_insert_char() flag Gabriel Somlo
2022-11-21 9:56 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 09/14] serial: liteuart: fix rx loop variable types Gabriel Somlo
2022-11-21 8:37 ` Jiri Slaby
2022-11-21 8:42 ` Jiri Slaby
2022-11-21 8:45 ` Jiri Slaby
2022-11-21 13:55 ` Gabriel L. Somlo
2022-11-22 7:37 ` Jiri Slaby
2022-11-22 21:05 ` Gabriel L. Somlo
2022-11-23 5:39 ` Jiri Slaby [this message]
2022-11-18 14:55 ` [PATCH v5 10/14] serial: liteuart: separate rx loop from poll timer Gabriel Somlo
2022-11-21 10:16 ` Geert Uytterhoeven
2022-11-21 16:44 ` Gabriel L. Somlo
2022-11-18 14:55 ` [PATCH v5 11/14] serial: liteuart: move function definitions Gabriel Somlo
2022-11-21 10:17 ` Geert Uytterhoeven
2022-11-18 14:55 ` [PATCH v5 12/14] serial: liteuart: add IRQ support for the RX path Gabriel Somlo
2022-11-21 8:54 ` Jiri Slaby
2022-11-21 18:50 ` Gabriel L. Somlo
2022-11-22 7:44 ` Jiri Slaby
2022-11-22 9:54 ` Geert Uytterhoeven
2022-11-22 19:41 ` Gabriel L. Somlo
2022-11-18 14:55 ` [PATCH v5 13/14] serial: liteuart: add IRQ support for the TX path Gabriel Somlo
2022-11-21 8:58 ` Jiri Slaby
2022-11-21 14:07 ` Gabriel L. Somlo
2022-11-18 14:55 ` [PATCH v5 14/14] serial: liteuart: move polling putchar() function Gabriel Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5888b92-ed6c-98c7-0d38-982a31e10e4f@kernel.org \
--to=jirislaby@kernel.org \
--cc=david.abdurachmanov@gmail.com \
--cc=florent@enjoy-digital.fr \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gsomlo@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mholenko@antmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).