From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3A7C76196 for ; Mon, 10 Apr 2023 12:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjDJMZr (ORCPT ); Mon, 10 Apr 2023 08:25:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjDJMZr (ORCPT ); Mon, 10 Apr 2023 08:25:47 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3511B524C; Mon, 10 Apr 2023 05:25:46 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4B83666015EC; Mon, 10 Apr 2023 13:25:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681129544; bh=/RVh0dF7TlKpEKSukKX6XhJ5f7HG7CyPyfJnYGJ2eq8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n8Ma5Eku/5McQqNsu8IwFYxw9KnoVuC23Rj6LAtvNIsToqBsfeh0EUFCd/RWqEnwQ i4qJQCTKRp1n6d/poomD2CDLmPg1CyS5APgoZYLfXybo50KhK47D7fUdEotp1WwIxn Qfl++XOIdVvDwXxTV6YTO6/TBGuYdkbYWYtpqTuD1KWIrByMgUz1i1bHhotfQR+jDX ZlWYpAr8oi8u6eUSd5j6H/g+mVk82Ujm4ESzZjwnyLO8vHX5xB6/LWSf5hMcXG3CLl tc0pcpRzfS1C1oGS7iXJpQK+p8n3vHZU1wILmBTNtcfkLgYB0H/k+C2ue2DXRq0tMZ PY9Eus4cb4YFw== Message-ID: Date: Mon, 10 Apr 2023 15:25:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 06/10] riscv: dts: allwinner: d1: Switch dma-names order for snps,dw-apb-uart nodes To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nicolas Frattaroli Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com References: <20230321215624.78383-1-cristian.ciocaltea@collabora.com> <20230321215624.78383-7-cristian.ciocaltea@collabora.com> <1945003.usQuhbGJ8B@jernej-laptop> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <1945003.usQuhbGJ8B@jernej-laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 4/8/23 15:36, Jernej Škrabec wrote: > Dne torek, 21. marec 2023 ob 22:56:20 CEST je Cristian Ciocaltea napisal(a): >> Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & >> dma-names properties") documented dma-names property to handle Allwinner >> D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the >> reverse of what a bunch of different boards expect. >> >> The initial proposed solution was to allow a flexible dma-names order in >> the binding, due to potential ABI breakage concerns after fixing the DTS >> files. But luckily the Allwinner boards are not affected, since they are >> using a shared DMA channel for rx and tx. >> >> Hence, the first step in fixing the inconsistency was to change >> dma-names order in the binding to tx->rx. >> >> Do the same for the snps,dw-apb-uart nodes in the DTS file. >> >> Signed-off-by: Cristian Ciocaltea > > Applied patches 2-6, thanks! Hi Jernej, Please note the patches have been already picked by Greg and were merged in next-20230331. Regards, Cristian