From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBDA18DB05; Mon, 14 Apr 2025 07:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744614487; cv=none; b=hqiYTmE383MRmanqMn6GytFfZMS+viRLBHM8RVXEk+4bqry1EjeUebTWdrbBjNxfWo0bVAPueoZTs4A51aCOwIydKp4XvaG7pwN8apV768GLQEffZy19FNZQI1DtAlvDhT2k/uCXNnjpTYGSV4RPnW20xKdWBScK96Pc1bPMLRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744614487; c=relaxed/simple; bh=6ZmtbtJwLqv+YeOMs/9a8sJ2IYK/XhXWDZMXKLzoxpA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STCDBGR9VHzew/+NbUQq4LwBZf0vAaGUfl2xVeRWmydB7eejqh4FCu2JUHFuDIBxj9QYuWD3xY8EKqR/XRjEluLJAeRdzcw1CKQJITGS+e04atjICzML1Nljezvo4f3i/v/SDqebCgpLErO3TlnYc0Do5/lObBW8cAHeHdP700A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UZWEYgdz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UZWEYgdz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3B32C4CEE2; Mon, 14 Apr 2025 07:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744614487; bh=6ZmtbtJwLqv+YeOMs/9a8sJ2IYK/XhXWDZMXKLzoxpA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UZWEYgdzNIPo6xMutGOYW5EU708s2iail4EsbnnARTsLywXY9ajDeC8eEPXpPIW41 WfuaeAsCDpIgpdnZeg1MSTX1PVnP74wS+w3oLh0DwGmgDk+8IFfpdsZ33NRZBpZfoO Z51x6mY6BwVlhQobszuGUsEBa4KRo2iV6/Kq+PbwSAtyvo84xdmWl3WUQ+Zq2P4KIj KY8w7JGQvRK9LTaDromkqxPDr79lWHR5omP2KZM366Zv5mlJocbEuS5uwUvPpJJq51 7osrEsRr48qIHzv4WwnIIPpVcO47pEymjFfVcSDE4YjaeqQVAPPvXZVe9NMHP3r15h aEYy/96aoITDA== Message-ID: Date: Mon, 14 Apr 2025 09:08:04 +0200 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] vt: introduce gen_ucs_recompose.py to create ucs_recompose.c To: Nicolas Pitre , Greg Kroah-Hartman Cc: Nicolas Pitre , Dave Mielke , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250410011839.64418-1-nico@fluxnic.net> <20250410011839.64418-7-nico@fluxnic.net> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20250410011839.64418-7-nico@fluxnic.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10. 04. 25, 3:13, Nicolas Pitre wrote: > From: Nicolas Pitre > > The generated code includes a table that maps base character + combining > mark pairs to their precomposed equivalents using Python's unicodedata > module. It also provides the ucs_recompose() function to query that > table. > > The default script behavior is to create a table with most commonly used > Latin, Greek, and Cyrillic recomposition pairs only. It is much smaller > than the table with all possible recomposition pairs (71 entries vs 1000 > entries). But if one needs/wants the full table then simply running the > script with the --full argument will generate it. > > Signed-off-by: Nicolas Pitre > --- > drivers/tty/vt/gen_ucs_recompose.py | 321 ++++++++++++++++++++++++++++ > 1 file changed, 321 insertions(+) > create mode 100755 drivers/tty/vt/gen_ucs_recompose.py > > diff --git a/drivers/tty/vt/gen_ucs_recompose.py b/drivers/tty/vt/gen_ucs_recompose.py > new file mode 100755 > index 0000000000..64418803e4 > --- /dev/null > +++ b/drivers/tty/vt/gen_ucs_recompose.py ... > +struct compare_key {{ > + uint16_t base; > + uint16_t combining; > +}}; > + > +static int recomposition_compare(const void *key, const void *element) > +{{ > + const struct compare_key *search_key = key; > + const struct recomposition *table_entry = element; > + > + /* Compare base character first */ > + if (search_key->base < table_entry->base) > + return -1; > + if (search_key->base > table_entry->base) > + return 1; > + > + /* Base characters match, now compare combining character */ > + if (search_key->combining < table_entry->combining) > + return -1; > + if (search_key->combining > table_entry->combining) > + return 1; > + > + /* Both match */ > + return 0; > +}} > + > +/** > + * Attempt to recompose two Unicode characters into a single character. > + * > + * @param previous: Previous Unicode code point (UCS-4) > + * @param current: Current Unicode code point (UCS-4) > + * Return: Recomposed Unicode code point, or 0 if no recomposition is possible > + */ > +uint32_t ucs_recompose(uint32_t base, uint32_t combining) > +{{ > + /* Check if characters are within the range of our table */ > + if (base < MIN_BASE_CHAR || base > MAX_BASE_CHAR || > + combining < MIN_COMBINING_CHAR || combining > MAX_COMBINING_CHAR) > + return 0; > + > + struct compare_key key = {{ base, combining }}; > + > + struct recomposition *result = > + __inline_bsearch(&key, recomposition_table, > + ARRAY_SIZE(recomposition_table), > + sizeof(*recomposition_table), > + recomposition_compare); > + > + return result ? result->recomposed : 0; > +}} Again, I think no reason to maintain C functions in py. thanks, -- js suse labs