From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ravi Patel <ravi.patel@samsung.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
jesper.nilsson@axis.com, lars.persson@axis.com,
alim.akhtar@samsung.com, arnd@kernel.org
Cc: andriy.shevchenko@linux.intel.com, geert+renesas@glider.be,
thierry.bultel.yh@bp.renesas.com, dianders@chromium.org,
robert.marko@sartura.hr, schnelle@linux.ibm.com,
kkartik@nvidia.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com,
ksk4725@coasia.com, kenkim@coasia.com, smn1196@coasia.com,
pjsin865@coasia.com, shradha.t@samsung.com
Subject: Re: [PATCH 1/3] dt-bindings: serial: samsung: Update axis,artpec8-uart to use samsung,uart-fifosize
Date: Thu, 11 Sep 2025 16:32:34 +0200 [thread overview]
Message-ID: <b9a2c3cc-49d6-480c-8c57-fffe0cf9d527@kernel.org> (raw)
In-Reply-To: <20250911141605.13034-2-ravi.patel@samsung.com>
On 11/09/2025 16:16, Ravi Patel wrote:
> Update the axis,artpec8-uart compatible such that it uses the
> samsung,uart-fifosize as required property.
>
> This is to remove the axis,artpec8-uart specific code (which is
> kind of duplicated) from the driver and use the other matching
> exynos8895 uart code for ARTPEC-8.
>
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> ---
> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index 1a1f991d5364..08eceaae2921 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -152,7 +152,6 @@ allOf:
> contains:
> enum:
> - apple,s5l-uart
> - - axis,artpec8-uart
> - samsung,exynos4210-uart
> - samsung,exynos5433-uart
You need to start testing patches, because this obviously fails basic
tests. And toolset would tell you if you bothered.
This does not fit documented Samsung SoC maintainer rules (because of (1)).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-11 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250911141702epcas5p23d6a0708919eca66f9b29104efafbc1f@epcas5p2.samsung.com>
2025-09-11 14:16 ` [PATCH 0/3] Use exynos8895 driver data for ARTPEC-8 platform Ravi Patel
2025-09-11 14:16 ` [PATCH 1/3] dt-bindings: serial: samsung: Update axis,artpec8-uart to use samsung,uart-fifosize Ravi Patel
2025-09-11 14:32 ` Krzysztof Kozlowski [this message]
2025-09-11 15:52 ` Ravi Patel
2025-09-11 14:16 ` [PATCH 2/3] arm64: dts: axis: Add samsung,exynos8895-uart compatible for serial node Ravi Patel
2025-09-11 14:24 ` Krzysztof Kozlowski
2025-09-11 14:16 ` [PATCH 3/3] tty: serial: samsung: Remove unused artpec-8 specific code Ravi Patel
2025-09-11 14:27 ` Geert Uytterhoeven
2025-09-11 14:29 ` Krzysztof Kozlowski
2025-09-11 14:35 ` Krzysztof Kozlowski
2025-09-11 16:04 ` Ravi Patel
2025-09-11 17:22 ` Krzysztof Kozlowski
2025-09-12 5:19 ` Ravi Patel
2025-09-12 13:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a2c3cc-49d6-480c-8c57-fffe0cf9d527@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jesper.nilsson@axis.com \
--cc=jirislaby@kernel.org \
--cc=kenkim@coasia.com \
--cc=kkartik@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ksk4725@coasia.com \
--cc=lars.persson@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pjsin865@coasia.com \
--cc=ravi.patel@samsung.com \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=shradha.t@samsung.com \
--cc=smn1196@coasia.com \
--cc=thierry.bultel.yh@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox