From: Jiri Slaby <jirislaby@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>,
Abinash Singh <abinashsinghlalotra@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] tty: serial/8250: Fix build warning in serial8250_probe_acpi()
Date: Thu, 7 Aug 2025 07:25:06 +0200 [thread overview]
Message-ID: <b9f715c0-082f-46a3-b332-d5f6bf53ad71@kernel.org> (raw)
In-Reply-To: <f765eae4-f83e-4c25-9697-2705afd7b9b8@app.fastmail.com>
On 06. 08. 25, 9:01, Arnd Bergmann wrote:
> Note how serial8250_register_8250_port() ands up just copying
> individual members of the passed uart_8250_port structure into
> the global array of the same type, so one way of addressing
> this would be to use a structure for initialization that only
> contains a subset of the uart_8250_port members and can still
> be allocated on the stack, or possibly be constant.
Yes:
https://lore.kernel.org/all/f84c2ee3-77b4-41c4-8517-26dfb44a2276@kernel.org/
--
js
suse labs
next prev parent reply other threads:[~2025-08-07 5:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 19:51 [RFC PATCH 1/2] tty: serial/8250: Fix build warning in serial8250_probe_acpi() Abinash Singh
2025-08-05 19:51 ` [RFC PATCH 2/2] tty: serial/8250: Fix build warning in serial8250_probe_platform() Abinash Singh
2025-08-05 22:20 ` Andy Shevchenko
2025-08-06 20:10 ` [PATCH v2 0/2] serial: 8250_platform: Reduce stack usage in probe functions Abinash Singh
2025-08-06 20:10 ` [PATCH v2 1/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_acpi() Abinash Singh
2025-08-06 20:41 ` Andy Shevchenko
2025-08-06 20:10 ` [PATCH v2 2/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_platform() Abinash Singh
2025-08-06 20:43 ` Andy Shevchenko
2025-08-06 20:39 ` [PATCH v2 0/2] serial: 8250_platform: Reduce stack usage in probe functions Andy Shevchenko
2025-08-06 21:51 ` [PATCH v3 " Abinash Singh
2025-08-06 21:51 ` [PATCH v3 1/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_acpi() Abinash Singh
2025-08-06 21:51 ` [PATCH v3 2/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_platform() Abinash Singh
2025-08-09 9:47 ` [PATCH v3 0/2] serial: 8250_platform: Reduce stack usage in probe functions Andy Shevchenko
2025-08-05 22:17 ` [RFC PATCH 1/2] tty: serial/8250: Fix build warning in serial8250_probe_acpi() Andy Shevchenko
2025-08-06 7:01 ` Arnd Bergmann
2025-08-06 21:06 ` Abinash Singh
2025-08-07 5:25 ` Jiri Slaby [this message]
2025-08-07 6:43 ` Jiri Slaby
2025-08-07 7:37 ` Jiri Slaby
2025-08-07 11:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f715c0-082f-46a3-b332-d5f6bf53ad71@kernel.org \
--to=jirislaby@kernel.org \
--cc=abinashsinghlalotra@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox