From: Jiri Slaby <jirislaby@kernel.org>
To: kernel test robot <lkp@intel.com>, gregkh@linuxfoundation.org
Cc: kbuild-all@lists.01.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, johan@kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Tobias Klauser <tklauser@distanz.ch>,
Russell King <linux@armlinux.org.uk>,
Vineet Gupta <vgupta@kernel.org>,
Richard Genoud <richard.genoud@gmail.com>
Subject: Re: [PATCH 10/11] serial: make uart_console_write->putchar()'s character a char
Date: Wed, 26 Jan 2022 08:26:48 +0100 [thread overview]
Message-ID: <bf35dee8-4f0c-a91e-de89-0c39c749a650@kernel.org> (raw)
In-Reply-To: <202201242255.WTSwb6EN-lkp@intel.com>
On 24. 01. 22, 15:30, kernel test robot wrote:
> Hi Jiri,
>
> I love your patch! Yet something to improve:
Please skip this patch. I wonder why the bot didn't catch it in my queue
already.
> [auto build test ERROR on tty/tty-testing]
> [also build test ERROR on v5.17-rc1 next-20220124]
> [cannot apply to shawnguo/for-next davem-sparc/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Jiri-Slaby/TTY-patches-for-5-18/20220124-151758
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: microblaze-randconfig-r006-20220124 (https://download.01.org/0day-ci/archive/20220124/202201242255.WTSwb6EN-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/45520d4f6db241db0b77f41162adba4a9977956c
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Jiri-Slaby/TTY-patches-for-5-18/20220124-151758
> git checkout 45520d4f6db241db0b77f41162adba4a9977956c
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/tty/serial/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/tty/serial/sprd_serial.c: In function 'sprd_console_write':
>>> drivers/tty/serial/sprd_serial.c:1007:44: error: passing argument 4 of 'uart_console_write' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 1007 | uart_console_write(port, s, count, sprd_console_putchar);
> | ^~~~~~~~~~~~~~~~~~~~
> | |
> | void (*)(struct uart_port *, int)
> In file included from drivers/tty/serial/sprd_serial.c:18:
> include/linux/serial_core.h:402:32: note: expected 'void (*)(struct uart_port *, char)' but argument is of type 'void (*)(struct uart_port *, int)'
> 402 | void (*putchar)(struct uart_port *, char));
> | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
>
> vim +/uart_console_write +1007 drivers/tty/serial/sprd_serial.c
>
> b7396a38fb28db Chunyan Zhang 2015-01-28 992
> b7396a38fb28db Chunyan Zhang 2015-01-28 993 static void sprd_console_write(struct console *co, const char *s,
> b7396a38fb28db Chunyan Zhang 2015-01-28 994 unsigned int count)
> b7396a38fb28db Chunyan Zhang 2015-01-28 995 {
> b7396a38fb28db Chunyan Zhang 2015-01-28 996 struct uart_port *port = &sprd_port[co->index]->port;
> b7396a38fb28db Chunyan Zhang 2015-01-28 997 int locked = 1;
> b7396a38fb28db Chunyan Zhang 2015-01-28 998 unsigned long flags;
> b7396a38fb28db Chunyan Zhang 2015-01-28 999
> b7396a38fb28db Chunyan Zhang 2015-01-28 1000 if (port->sysrq)
> b7396a38fb28db Chunyan Zhang 2015-01-28 1001 locked = 0;
> b7396a38fb28db Chunyan Zhang 2015-01-28 1002 else if (oops_in_progress)
> b7396a38fb28db Chunyan Zhang 2015-01-28 1003 locked = spin_trylock_irqsave(&port->lock, flags);
> b7396a38fb28db Chunyan Zhang 2015-01-28 1004 else
> b7396a38fb28db Chunyan Zhang 2015-01-28 1005 spin_lock_irqsave(&port->lock, flags);
> b7396a38fb28db Chunyan Zhang 2015-01-28 1006
> b7396a38fb28db Chunyan Zhang 2015-01-28 @1007 uart_console_write(port, s, count, sprd_console_putchar);
> b7396a38fb28db Chunyan Zhang 2015-01-28 1008
> b7396a38fb28db Chunyan Zhang 2015-01-28 1009 /* wait for transmitter to become empty */
> b7396a38fb28db Chunyan Zhang 2015-01-28 1010 wait_for_xmitr(port);
> b7396a38fb28db Chunyan Zhang 2015-01-28 1011
> b7396a38fb28db Chunyan Zhang 2015-01-28 1012 if (locked)
> b7396a38fb28db Chunyan Zhang 2015-01-28 1013 spin_unlock_irqrestore(&port->lock, flags);
> b7396a38fb28db Chunyan Zhang 2015-01-28 1014 }
> b7396a38fb28db Chunyan Zhang 2015-01-28 1015
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
js
suse labs
next prev parent reply other threads:[~2022-01-26 7:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 7:14 [PATCH 00/11] TTY patches for 5.18 Jiri Slaby
2022-01-24 7:14 ` [PATCH 01/11] serial: core: clean up EXPORT_SYMBOLs Jiri Slaby
2022-01-24 7:14 ` [PATCH 02/11] serial: atmel_serial: include circ_buf.h Jiri Slaby
2022-01-24 8:46 ` Richard Genoud
2022-01-24 8:49 ` Richard Genoud
2022-01-24 7:14 ` [PATCH 03/11] tty: add kfifo to tty_port Jiri Slaby
2022-01-24 7:14 ` [PATCH 04/11] tty: tty_port_open, document shutdown vs failed activate Jiri Slaby
2022-01-24 7:14 ` [PATCH 05/11] mxser: fix xmit_buf leak in activate when LSR == 0xff Jiri Slaby
2022-01-24 7:14 ` [PATCH 06/11] mxser: use tty_port xmit_buf helpers Jiri Slaby
2022-01-24 7:14 ` [PATCH 07/11] mxser: switch from xmit_buf to kfifo Jiri Slaby
2022-01-24 7:14 ` [PATCH 08/11] serial: fsl_linflexuart: deduplicate character sending Jiri Slaby
2022-01-24 7:14 ` [PATCH 09/11] serial: fsl_linflexuart: don't call uart_write_wakeup() twice Jiri Slaby
2022-01-24 7:14 ` [PATCH 10/11] serial: make uart_console_write->putchar()'s character a char Jiri Slaby
2022-01-24 9:06 ` Richard Genoud
2022-01-24 14:30 ` kernel test robot
2022-01-26 7:26 ` Jiri Slaby [this message]
2022-01-26 13:55 ` Greg KH
2022-01-24 16:23 ` kernel test robot
2022-01-26 17:57 ` Maciej W. Rozycki
2022-01-27 8:09 ` Jiri Slaby
2022-01-24 7:14 ` [PATCH 11/11] serial: mcf: use helpers in mcf_tx_chars() Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf35dee8-4f0c-a91e-de89-0c39c749a650@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=paul@crapouillou.net \
--cc=richard.genoud@gmail.com \
--cc=tklauser@distanz.ch \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).