Re: [PATCH 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios

[Hui Wang <hui.wang@canonical.com>]

On 6/3/24 21:18, Rob Herring wrote:
> On Mon, Jun 03, 2024 at 08:37:09PM +0800, Hui Wang wrote:
>> In some designs, the chip reset pin is connected to a gpio, this
>> gpio needs to be set correctly before probing the driver, so adding
>> a reset-gpios in the device tree.
>>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>>   Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
>> index 5dec15b7e7c3..62aff6e034cb 100644
>> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
>> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
>> @@ -28,6 +28,9 @@ properties:
>>     clocks:
>>       maxItems: 1
>>   
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>>     clock-frequency:
>>       description:
>>         When there is no clock provider visible to the platform, this
>> @@ -120,6 +123,7 @@ examples:
>>               compatible = "nxp,sc16is752";
>>               reg = <0x54>;
>>               clocks = <&clk20m>;
>> +            reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> Missing the header for the define.
>
> Test your bindings before sending.

OK, got it.

Thanks.

>
>>               interrupt-parent = <&gpio3>;
>>               interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>>               nxp,modem-control-line-ports = <0 1>; /* Ports 0 and 1 as modem control lines */
>> -- 
>> 2.34.1
>>