From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBB5D77107; Fri, 13 Sep 2024 07:39:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726213156; cv=none; b=Zd8Syj4jcS8gq/3oOe12WTjazhG8QsOh1cMSDLb+fpLegNaqEuB5HDlC9qAQEFu2xE5g+eNjOxgEnh0wJiVjbPpc/zKR8Jh1YYqpZjGJ6SiZIp/N23JvuZMoo2a44qsGbiUxbxM7BYBceyInsNOb7I1NB9V/XRF2UzoaYRv7cLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726213156; c=relaxed/simple; bh=uSyl591C5MSuYYRCXat18gjmBfYxAn2yaEESrJ+vCXI=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=H2S5Yl46N2s+LbhEeckhI6B39PVwKb9HEMfkDqdggTpmKl0N3VEZv+Bs6hcLdOc7FJVg3s2Lxf/jfUaVQ9HMDq2/pBhLioi7DLZYKydkB/5UP2DTN6agr9JK0vissUoV9VdkT+MoZLtW/5ubqm88pmHv022OB9OkMTyGC06JX+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=A+0QKa3F; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=c5BSoSaD; arc=none smtp.client-ip=103.168.172.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="A+0QKa3F"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="c5BSoSaD" Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 113AB13805FD; Fri, 13 Sep 2024 03:39:14 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 13 Sep 2024 03:39:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726213154; x=1726299554; bh=4RxENSVw+QennMKyvBqiq7B8zuv7KrZS6yfqHV9YR9U=; b= A+0QKa3F2pM5dRKOawqql+cT7ZceMYNyLwbR0eDvRxpXMYTtnpBhHp0qnpORpbsN ZZrmYqbMHAax8SZV7XJABh4JSIl1t6hJICfvKP+xhjIuYHYwW/K9XEAIy4fBKyZf /nj+EZoKL+MAQk+gtx9aPHkcqYE6476vp4NH2EY6R7KZu5QtCAK7WpXZUlEAieZO 0j2H/D9fpop//Bx80Rfm8X/jfY2KrhpGY6wW8HMHcmP0Pu/xjAXX69G9buVoMngu esoH2b/sBLP5PIkYHALp5Ina4LYOCRNSFCD+iJb4S/1v7utolwoYxudoXQvINCwX bzVHl5FA6ERa/9o8X/T+7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726213154; x= 1726299554; bh=4RxENSVw+QennMKyvBqiq7B8zuv7KrZS6yfqHV9YR9U=; b=c 5BSoSaDhmXTG7OlfFJgDKDzVpptqCJUOw4Ce4j8KDHEX4CfgLmG/ntkxgipb5zgB UAaNycUggiC8uu0FWT8vc12OmViPHGlfxHXpvhQOQnFmMV3tBr5TfOgySUj+k9+e yxg1o2Ouoatnc1VI5VFCvCbsUFtmTXUA8mKC5ghGqSWoxwXzzcQlRqyFqdZvoFe2 qYrvalDDgXq5yne3X7XPefiGkPib4B/6/2iT/BEZSMLStoQFjzTI4lI1biAgtsEd Ka09afVhgmvSsrjWa33CpnCKvbTJl5upWx07OZr5iQClYe3ejR3osfcP/oaUA3Pd QFRUXsOxFDImgR3J3D4NA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejiedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvdek pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehuthhsrghvrdgrghgrrhifrghlse grnhgrlhhoghdrtghomhdprhgtphhtthhopegrughsphdqlhhinhhugiesrghnrghlohhg rdgtohhmpdhrtghpthhtoheprghrthhurhhsrdgrrhhtrghmohhnohhvshesrghnrghloh hgrdgtohhmpdhrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtgho mhdprhgtphhtthhopehmthhurhhquhgvthhtvgessggrhihlihgsrhgvrdgtohhmpdhrtg hpthhtohepsghrghhlsegsghguvghvrdhplhdprhgtphhtthhopegrnhguihdrshhhhiht iheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlh drohhrghdprhgtphhtthhopehjihhrihhslhgrsgihsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 9A1EB222006F; Fri, 13 Sep 2024 03:39:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 13 Sep 2024 07:38:51 +0000 From: "Arnd Bergmann" To: arturs.artamonovs@analog.com, "Catalin Marinas" , "Will Deacon" , "Greg Malysa" , "Philipp Zabel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Utsav Agarwal" , "Michael Turquette" , "Stephen Boyd" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Andi Shyti" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Olof Johansson" , soc@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, adsp-linux@analog.com, "Nathan Barrett-Morrison" Message-Id: In-Reply-To: <20240912-test-v1-9-458fa57c8ccf@analog.com> References: <20240912-test-v1-0-458fa57c8ccf@analog.com> <20240912-test-v1-9-458fa57c8ccf@analog.com> Subject: Re: [PATCH 09/21] gpio: add driver for ADI ADSP-SC5xx platform Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > + > +#include > +#include > +#include > +#include > +#include > +#include "gpiolib.h" > + > +static int adsp_gpio_direction_input(struct gpio_chip *chip, unsigned > int offset) > +{ > + struct adsp_gpio_port *port = to_adsp_gpio_port(chip); > + > + __adsp_gpio_writew(port, BIT(offset), ADSP_PORT_REG_DIR_CLEAR); > + __adsp_gpio_writew(port, BIT(offset), ADSP_PORT_REG_INEN_SET); > + return 0; What is the purpose of these __adsp_gpio_writew() in a global header? Can't those be moved into this file directly? > \ No newline at end of file Whitespace damage? Arnd