From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: John Keeping <jkeeping@inmusicbrands.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Wentao Guan" <guanwentao@uniontech.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ferry Toth" <ftoth@exalondelft.nl>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250_dma: terminate correct DMA in tx_dma_flush()
Date: Wed, 19 Mar 2025 14:21:39 +0200 (EET) [thread overview]
Message-ID: <c452c05a-b6ad-144a-2738-ba52d57e7eef@linux.intel.com> (raw)
In-Reply-To: <20250224121831.1429323-1-jkeeping@inmusicbrands.com>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On Mon, 24 Feb 2025, John Keeping wrote:
> When flushing transmit side DMA, it is the transmit channel that should
> be terminated, not the receive channel.
>
> Fixes: 9e512eaaf8f40 ("serial: 8250: Fix fifo underflow on flush")
> Reported-by: Wentao Guan <guanwentao@uniontech.com>
> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
> ---
> drivers/tty/serial/8250/8250_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
> index f245a84f4a508..bdd26c9f34bdf 100644
> --- a/drivers/tty/serial/8250/8250_dma.c
> +++ b/drivers/tty/serial/8250/8250_dma.c
> @@ -162,7 +162,7 @@ void serial8250_tx_dma_flush(struct uart_8250_port *p)
> */
> dma->tx_size = 0;
>
> - dmaengine_terminate_async(dma->rxchan);
> + dmaengine_terminate_async(dma->txchan);
> }
>
> int serial8250_rx_dma(struct uart_8250_port *p)
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2025-03-19 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 12:18 [PATCH] serial: 8250_dma: terminate correct DMA in tx_dma_flush() John Keeping
2025-02-24 12:36 ` Wentao Guan
2025-02-24 12:48 ` [PATCH] " Greg KH
2025-02-24 12:48 ` Greg KH
2025-02-24 13:13 ` Wentao Guan
2025-02-24 13:34 ` Greg KH
2025-02-24 16:51 ` Slade Watkins
2025-02-25 11:37 ` Wentao Guan
2025-03-19 6:14 ` Wentao Guan
2025-03-19 11:20 ` [PATCH] " Greg KH
2025-03-19 12:15 ` Wentao Guan
2025-03-19 12:21 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c452c05a-b6ad-144a-2738-ba52d57e7eef@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=ftoth@exalondelft.nl \
--cc=gregkh@linuxfoundation.org \
--cc=guanwentao@uniontech.com \
--cc=jirislaby@kernel.org \
--cc=jkeeping@inmusicbrands.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox