From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD1CC32771 for ; Wed, 28 Sep 2022 11:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbiI1LwI (ORCPT ); Wed, 28 Sep 2022 07:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233083AbiI1LwH (ORCPT ); Wed, 28 Sep 2022 07:52:07 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 004611BC; Wed, 28 Sep 2022 04:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664365927; x=1695901927; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=JbPedr5Aug0M5rs26jYGMN7zaZdiXgsSQ4iu0gsMQUQ=; b=gZJ7A2BMy8QZzt+PRwQRjwDg9zgpLVZZjvZih30akIU7Z5llXOZ2PqOR rDf9Zhm4M7Tb1FCZVdu/l72k39/XgeZO2jAE/Cd0SVofMIQUvdYgfIHfx kf7ooK4QS4osHh2M8cCOBwMp6M/EVuN4PIS3cxoNhDf1AgDlz5nol/JAR SJq9nlOGcVJvT0pK0OUpx0FDqChgt+6WU1Oa78ACBR6btdOoszzfiOKDU h8V8UzEATxjAEyHjw7EaMYR7gAt5CwngkIsYWw2M1vgzQUcNxCliCISLt pMQE43VeQcMnctgF8afuBY16MwzrA5LK6oSMenjsFNfeweyShJ5Tmgsfb A==; X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="303064158" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="303064158" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 04:52:06 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="599549670" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="599549670" Received: from kjurkiew-mobl.ger.corp.intel.com ([10.251.211.248]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 04:52:04 -0700 Date: Wed, 28 Sep 2022 14:52:02 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Andy Shevchenko cc: Jiri Slaby , Greg Kroah-Hartman , linux-serial , Jonathan Corbet , linux-doc@vger.kernel.org, LKML Subject: Re: [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485_mode() In-Reply-To: Message-ID: References: <20220928110509.13544-1-ilpo.jarvinen@linux.intel.com> <20220928110509.13544-4-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1426318885-1664365926=:1695" Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1426318885-1664365926=:1695 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 28 Sep 2022, Andy Shevchenko wrote: > On Wed, Sep 28, 2022 at 2:05 PM Ilpo Järvinen > wrote: > > > The device tree can also provide RS485 boot time parameters > > - [#DT-bindings]_. The driver is in charge of filling this data structure > > - from the values given by the device tree. > > + [#DT-bindings]_. The serial core fills the struct serial_rs485 from the > > + values given by the device tree when driver calls uart_get_rs485_mode(). > > the driver > > Feels like this should be before the previous patch and actually have > a Fixes tag. I don't feel it would be an appropriate tag for this kind of cases where documentation is simply lacking behind what the core code now offers. -- i. --8323329-1426318885-1664365926=:1695--