[PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610

linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 16:30   ` Greg KH
  2020-12-05 14:20 ` [PATCH 2/8] tty: serial: jsm: Fixed file by added more spacing in line 611 Clement Smith
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

Fixed a coding style issue

Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 689774c073ca..512b77195e9f 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -607,7 +607,7 @@ void jsm_input(struct jsm_channel *ch)
 				 * Give the Linux ld the flags in the
 				 * format it likes.
 				 */
-				if (*(ch->ch_equeue +tail +i) & UART_LSR_BI)
+				if (*(ch->ch_equeue + tail + i) & UART_LSR_BI)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i),  TTY_BREAK);
 				else if (*(ch->ch_equeue +tail +i) & UART_LSR_PE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_PARITY);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610
  2020-12-05 14:20 ` [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610 Clement Smith
@ 2020-12-05 16:30   ` Greg KH
  0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2020-12-05 16:30 UTC (permalink / raw)
  To: Clement Smith; +Cc: linux-serial, linux-kernel

On Sat, Dec 05, 2020 at 07:50:08PM +0530, Clement Smith wrote:
> Fixed a coding style issue
> 
> Signed-off-by: Clement Smith <rclemsmith@gmail.com>
> ---
>  drivers/tty/serial/jsm/jsm_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The subject lines in this series is really funny.

Please don't do this.  If you want to get practice in making coding
style cleanups, do it in drivers/staging/ which is why the code is
there.  Don't "practice" in other parts of the kernel as it just gets in
the way of other development and review efforts.

good luck!

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/8] tty: serial: jsm: Fixed file by added more spacing in line 611
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
  2020-12-05 14:20 ` [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 14:20 ` [PATCH 3/8] tty: serial: jsm: Fixed file by added more spacing in line 612 Clement Smith
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

    Fixed a coding style issue

    Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 512b77195e9f..202d6ba93313 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -608,7 +608,7 @@ void jsm_input(struct jsm_channel *ch)
 				 * format it likes.
 				 */
 				if (*(ch->ch_equeue + tail + i) & UART_LSR_BI)
-					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i),  TTY_BREAK);
+					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i),  TTY_BREAK);
 				else if (*(ch->ch_equeue +tail +i) & UART_LSR_PE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_PARITY);
 				else if (*(ch->ch_equeue +tail +i) & UART_LSR_FE)
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/8] tty: serial: jsm: Fixed file by added more spacing in line 612
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
  2020-12-05 14:20 ` [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610 Clement Smith
  2020-12-05 14:20 ` [PATCH 2/8] tty: serial: jsm: Fixed file by added more spacing in line 611 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 14:20 ` [PATCH 4/8] tty: serial: jsm: Fixed file by added more spacing in line 613 Clement Smith
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

        Fixed a coding style issue

        Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 202d6ba93313..2bc5f32e59f4 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -609,7 +609,7 @@ void jsm_input(struct jsm_channel *ch)
 				 */
 				if (*(ch->ch_equeue + tail + i) & UART_LSR_BI)
 					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i),  TTY_BREAK);
-				else if (*(ch->ch_equeue +tail +i) & UART_LSR_PE)
+				else if (*(ch->ch_equeue + tail + i) & UART_LSR_PE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_PARITY);
 				else if (*(ch->ch_equeue +tail +i) & UART_LSR_FE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_FRAME);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/8] tty: serial: jsm: Fixed file by added more spacing in line 613
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
                   ` (2 preceding siblings ...)
  2020-12-05 14:20 ` [PATCH 3/8] tty: serial: jsm: Fixed file by added more spacing in line 612 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 14:20 ` [PATCH 5/8] tty: serial: jsm: Fixed file by added more spacing in line 614 Clement Smith
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

        Fixed a coding style issue

        Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 2bc5f32e59f4..45e212be64c4 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -610,7 +610,7 @@ void jsm_input(struct jsm_channel *ch)
 				if (*(ch->ch_equeue + tail + i) & UART_LSR_BI)
 					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i),  TTY_BREAK);
 				else if (*(ch->ch_equeue + tail + i) & UART_LSR_PE)
-					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_PARITY);
+					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_PARITY);
 				else if (*(ch->ch_equeue +tail +i) & UART_LSR_FE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_FRAME);
 				else
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 5/8] tty: serial: jsm: Fixed file by added more spacing in line 614
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
                   ` (3 preceding siblings ...)
  2020-12-05 14:20 ` [PATCH 4/8] tty: serial: jsm: Fixed file by added more spacing in line 613 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 14:20 ` [PATCH 6/8] tty: serial: jsm: Fixed file by added more spacing in line 615 Clement Smith
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

        Fixed a coding style issue

        Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 45e212be64c4..75c9bfa5077c 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -611,7 +611,7 @@ void jsm_input(struct jsm_channel *ch)
 					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i),  TTY_BREAK);
 				else if (*(ch->ch_equeue + tail + i) & UART_LSR_PE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_PARITY);
-				else if (*(ch->ch_equeue +tail +i) & UART_LSR_FE)
+				else if (*(ch->ch_equeue + tail + i) & UART_LSR_FE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_FRAME);
 				else
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_NORMAL);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 6/8] tty: serial: jsm: Fixed file by added more spacing in line 615
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
                   ` (4 preceding siblings ...)
  2020-12-05 14:20 ` [PATCH 5/8] tty: serial: jsm: Fixed file by added more spacing in line 614 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 14:20 ` [PATCH 7/8] tty: serial: jsm: Fixed file by added more spacing in line 616 Clement Smith
  2020-12-05 14:20 ` [PATCH 8/8] tty: serial: jsm: Removed assignment in if statement Clement Smith
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

        Fixed a coding style issue

        Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 75c9bfa5077c..19d2f0bc6c10 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -612,7 +612,7 @@ void jsm_input(struct jsm_channel *ch)
 				else if (*(ch->ch_equeue + tail + i) & UART_LSR_PE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_PARITY);
 				else if (*(ch->ch_equeue + tail + i) & UART_LSR_FE)
-					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_FRAME);
+					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_FRAME);
 				else
 					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_NORMAL);
 			}
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 7/8] tty: serial: jsm: Fixed file by added more spacing in line 616
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
                   ` (5 preceding siblings ...)
  2020-12-05 14:20 ` [PATCH 6/8] tty: serial: jsm: Fixed file by added more spacing in line 615 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  2020-12-05 14:20 ` [PATCH 8/8] tty: serial: jsm: Removed assignment in if statement Clement Smith
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

        Fixed a coding style issue

        Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index 19d2f0bc6c10..eab82fb6b384 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -614,7 +614,7 @@ void jsm_input(struct jsm_channel *ch)
 				else if (*(ch->ch_equeue + tail + i) & UART_LSR_FE)
 					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_FRAME);
 				else
-					tty_insert_flip_char(port, *(ch->ch_rqueue +tail +i), TTY_NORMAL);
+					tty_insert_flip_char(port, *(ch->ch_rqueue + tail + i), TTY_NORMAL);
 			}
 		} else {
 			tty_insert_flip_string(port, ch->ch_rqueue + tail, s);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 8/8] tty: serial: jsm: Removed assignment in if statement
       [not found] <cover.1607177807.git.rclemsmith@gmail.com>
                   ` (6 preceding siblings ...)
  2020-12-05 14:20 ` [PATCH 7/8] tty: serial: jsm: Fixed file by added more spacing in line 616 Clement Smith
@ 2020-12-05 14:20 ` Clement Smith
  7 siblings, 0 replies; 9+ messages in thread
From: Clement Smith @ 2020-12-05 14:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-serial, linux-kernel, Clement Smith

            Fixed a coding style issue

            Signed-off-by: Clement Smith <rclemsmith@gmail.com>
---
 drivers/tty/serial/jsm/jsm_tty.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index eab82fb6b384..bfd4b55e6c74 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -742,7 +742,8 @@ void jsm_check_queue_flow_control(struct jsm_channel *ch)
 	int qleft;
 
 	/* Store how much space we have left in the queue */
-	if ((qleft = ch->ch_r_tail - ch->ch_r_head - 1) < 0)
+    qleft = ch->ch_r_tail - ch->ch_r_head - 1;
+	if (qleft < 0)
 		qleft += RQUEUEMASK + 1;
 
 	/*
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-12-05 18:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1607177807.git.rclemsmith@gmail.com>
2020-12-05 14:20 ` [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610 Clement Smith
2020-12-05 16:30   ` Greg KH
2020-12-05 14:20 ` [PATCH 2/8] tty: serial: jsm: Fixed file by added more spacing in line 611 Clement Smith
2020-12-05 14:20 ` [PATCH 3/8] tty: serial: jsm: Fixed file by added more spacing in line 612 Clement Smith
2020-12-05 14:20 ` [PATCH 4/8] tty: serial: jsm: Fixed file by added more spacing in line 613 Clement Smith
2020-12-05 14:20 ` [PATCH 5/8] tty: serial: jsm: Fixed file by added more spacing in line 614 Clement Smith
2020-12-05 14:20 ` [PATCH 6/8] tty: serial: jsm: Fixed file by added more spacing in line 615 Clement Smith
2020-12-05 14:20 ` [PATCH 7/8] tty: serial: jsm: Fixed file by added more spacing in line 616 Clement Smith
2020-12-05 14:20 ` [PATCH 8/8] tty: serial: jsm: Removed assignment in if statement Clement Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).