From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] serial: 8250_dw: add fractional divisor support
Date: Tue, 03 Jul 2018 16:03:40 +0300 [thread overview]
Message-ID: <c9bf4c643f51ab222dbc0221acc47773ee3d1a9a.camel@linux.intel.com> (raw)
In-Reply-To: <20180703104816.031abbfc@xhacker.debian>
On Tue, 2018-07-03 at 10:48 +0800, Jisheng Zhang wrote:
> On Tue, 3 Jul 2018 10:22:57 +0800 Jisheng Zhang wrote:
> patching struct uart_port seems a bit overhead. After reading the code
> again, I propose another solution, similar as what dl_write() is used
> in
> 8250 core:
>
> 1.introduce the hook to struct uart_8250_port as my previous patches
> do,
>
> 2.rename current serial8250_set_divisor() as
> default_serial_get_divisor()
> then introduce a new serial8250_set_divisor() as:
> static inline void serial8250_set_divisor(struct uart_8250_port
> *up,....)
> {
> up->set_divisor();
> }
>
> and point up->set-divisor to default_serial_get_divisor
>
> what do you think about this solution?
Disagree. See my previous answer for details.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-07-03 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 10:04 [PATCH 0/2] serial: 8250_dw: add fractional divisor support Jisheng Zhang
2018-07-02 10:05 ` [PATCH 1/2] serial: 8250: introduce get_divisor() and set_divisor() hook Jisheng Zhang
2018-07-02 10:06 ` [PATCH 2/2] serial: 8250_dw: add fractional divisor support Jisheng Zhang
2018-07-02 10:18 ` [PATCH 0/2] " Andy Shevchenko
2018-07-02 11:51 ` Andy Shevchenko
2018-07-03 2:22 ` Jisheng Zhang
2018-07-03 2:48 ` Jisheng Zhang
2018-07-03 13:03 ` Andy Shevchenko [this message]
2018-07-03 13:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9bf4c643f51ab222dbc0221acc47773ee3d1a9a.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).