From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D526C18E5B for ; Tue, 17 Mar 2020 13:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 155B32075E for ; Tue, 17 Mar 2020 13:05:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ZFBcI5As" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbgCQNF5 (ORCPT ); Tue, 17 Mar 2020 09:05:57 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:38174 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbgCQNF5 (ORCPT ); Tue, 17 Mar 2020 09:05:57 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584450356; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=ZTED8PjW1HwvOigSt/VzJRJKGdN0cV9OXysHgYPS88c=; b=ZFBcI5AsJ1sS8tGI4YUS1IJJjjUGIE3piGGhlxvvZRxj1/kF8nnPl9nI2fQtE0aRqxT9/87c 3mm5VgcF33menoqqCQSvdARM04ryeXpJcJjNAQUH12p2U834tpPEzyIsGIYgff/w5haiy841 0LRwl4Do2/v0OdkSz64EV0P4Fqw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyIzZmY0MiIsICJsaW51eC1zZXJpYWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e70cb26.7f4eca5d7650-smtp-out-n04; Tue, 17 Mar 2020 13:05:42 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C4B25C4478F; Tue, 17 Mar 2020 13:05:40 +0000 (UTC) Received: from [192.168.0.8] (unknown [183.83.138.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id A2CA6C433CB; Tue, 17 Mar 2020 13:05:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A2CA6C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH 1/2] tty: serial: qcom_geni_serial: No need to stop tx/rx on UART shutdown To: Douglas Anderson , gregkh@linuxfoundation.org Cc: mka@chromium.org, swboyd@chromium.org, ryandcase@chromium.org, bjorn.andersson@linaro.org, skakit@codeaurora.org, rojay@codeaurora.org, mgautam@codeaurora.org, Andy Gross , Doug Anderson , Girish Mahadevan , Jiri Slaby , Karthikeyan Ramasubramanian , Sagar Dharia , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20200313134635.1.Icf54c533065306b02b880c46dfd401d8db34e213@changeid> From: Akash Asthana Message-ID: Date: Tue, 17 Mar 2020 18:35:31 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200313134635.1.Icf54c533065306b02b880c46dfd401d8db34e213@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 3/14/2020 2:16 AM, Douglas Anderson wrote: > On a board using qcom_geni_serial I found that I could no longer > interact with kdb if I got a crash after the "agetty" running on the > same serial port was killed. This meant that various classes of > crashes that happened at reboot time were undebuggable. > > Reading through the code, I couldn't figure out why qcom_geni_serial > felt the need to run so much code at port shutdown time. All we need > to do is disable the interrupt. > > After I make this change then a hardcoded kgdb_breakpoint in some late > shutdown code now allows me to interact with the debugger. I also > could freely close / re-open the port without problems. > > Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP") > Signed-off-by: Douglas Anderson > --- Looks good to me. Reviewed-by: Akash Asthana -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project