From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6C7C1EA0BB for ; Wed, 7 Aug 2024 13:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723038802; cv=none; b=qWb4ZvJ8iWBpUxqOJxb1lTqfStn56o6S2mSdt0eEAEc4b7EJJJ0ez4cSKRwlAssgW28Sq6eE7f+JrPHc1O6gnaUTpuslXC8CNNpuHv4u+vJG3vhG5zBM4eVLuwDC5As/KCUzFUQ2MLRnDvKx6vgt3KO1UpPJCbFI72uAXS2NwbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723038802; c=relaxed/simple; bh=NRqiEnBiimHoingme0qVJPrkh4WXTxTwsQB1Q7Y4gKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MyFiIFD+KFxc/shTYdGkfGvarLel9FHUMjeW+bZLAzHSN8dCbKZWuHxDSvDIwOdSb5IaZtqcNjOcAHQ+wGYGFSfSm0xLQ4a37iIFfyYQJELKWK7GOIfqsZVCDHJmOd7MkTHWi0LwC57vwv04FJGViMVXnlWqpGNz3KKqU1R5A3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=acwjPtsv; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="acwjPtsv" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5ba43b433beso2099141a12.1 for ; Wed, 07 Aug 2024 06:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723038799; x=1723643599; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AIu6O+iMzaxlTo7+/E6XE3a2FAHks2o/pMfGehr4SyQ=; b=acwjPtsvpKCewGLDC+c1KH/QucmcvkdNXNWH/p8B4s5FQWSXFfErMgPn/OwUTfqmsK j0gjjodWYrWgX8dtk/7fVbWZVdmCLnIfIsmoBFeJF1tVlgtGr9FkP2b9bHKD9ED6AWN8 +WsO5dTojhZtWNiJgyAohXysRdaaPANBip6HNrZMEoCv1Z/EZP9Q6JICGeyy5c9mqqh/ Las+pzMRD8iR/LCfG/x0/C0jxd0Cpeu0DtTxswrVe3CHnUZ2DGsqRtp/tOXgP9w7Zpby j7HBf2IbXpKex74vfpOmx0Il3mNu0vMUvH9RtnYwOIj46U9k6g3wO4RByTkxLHuVJ47L yu/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723038799; x=1723643599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AIu6O+iMzaxlTo7+/E6XE3a2FAHks2o/pMfGehr4SyQ=; b=bpHAsw29i26GeQwoTMJo0uZ/UhAwx23mNJRO45bb8uRFfpgaLhFW4pqVa5VHjfQ6ec DA0fpenuwSUfDGdgToED8Zft4AEHZ2sDFHhHlqYc0KjueBB0oiM5pWFEOsJ688SKfHpl 3U3N+BMi0UZ3Dj8jeO4/WJ3KbB8VJQ252uMJ8+JxmkDhfb6ZeMsnEc8J0YFjlwbsB/FY toN0xDheePTphxHQJgExPqaI1aPpECxtIJHB7kwzKnuqRA2drZGwVo8LDN33x+eHiWmm jOhPsysxWEUDeQ3Okb9qITw/ucWWxvyt0DD1TD6PwL8F8yfXVew7GKpHxblvoRr3+imZ kBvQ== X-Forwarded-Encrypted: i=1; AJvYcCWf53WpJv4o5BJbpxgRkaMs0nR5eDANGAB2aO0Q+GBXhUhtOfQYGjNqOB7ffN+nilokoA8qZ2PHNXZ3PhTuVawfVFg90sSCV70nc+jT X-Gm-Message-State: AOJu0Yx4AaK6fqxI5cNSIt/zki+PU+SWra7ZLkGzgqLr6tXCHlo80Xcf 5fwe5zDyR58CsZNHW5vSkTeB7h9XCQnYyMCFgOaWkXcM7rzCpngngSgkpoN0O70+AT3ClCSyK4f l X-Google-Smtp-Source: AGHT+IHR+S+EBDdfTlDpuRP9UXE7ZPm7Fw3uAAffraz5Q9GDxJ8ZoP7KdHbWzr+B8x/S7xiFhH8MmQ== X-Received: by 2002:a17:907:7204:b0:a7a:b070:92d1 with SMTP id a640c23a62f3a-a7dc517b48dmr1376018166b.46.1723038799127; Wed, 07 Aug 2024 06:53:19 -0700 (PDT) Received: from [192.168.0.157] ([79.115.63.215]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9c67a43sm639660866b.96.2024.08.07.06.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Aug 2024 06:53:18 -0700 (PDT) Message-ID: Date: Wed, 7 Aug 2024 14:53:16 +0100 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] tty: serial: samsung_tty: simple cleanups To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Greg Kroah-Hartman Cc: Krzysztof Kozlowski , Alim Akhtar , Jiri Slaby , Peter Griffin , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20240806-samsung-tty-cleanup-v1-0-a68d3abf31fe@linaro.org> <2024080714-spongy-wannabe-7a9e@gregkh> <5e73f1b405e06f9ee796d3b7002933f75613728a.camel@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <5e73f1b405e06f9ee796d3b7002933f75613728a.camel@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/7/24 1:00 PM, André Draszik wrote: > On Wed, 2024-08-07 at 13:09 +0200, Greg Kroah-Hartman wrote: >> On Tue, Aug 06, 2024 at 04:29:44PM +0100, André Draszik wrote: >>> While looking through the samsung tty driver, I've spotted a few things that >>> can be simplified by removing unused function arguments and by avoiding some >>> duplicated variables and casting. >>> >>> There are no functional changes here. >>> >>> Signed-off-by: André Draszik >>> --- >>> André Draszik (2): >>>       tty: serial: samsung_tty: drop unused argument to irq handlers >>>       tty: serial: samsung_tty: cast the interrupt's void *id just once >> >> This series blows up the build for me, are you sure you tested it? >> >> drivers/tty/serial/samsung_tty.c: In function ‘s3c64xx_serial_handle_irq’: >> drivers/tty/serial/samsung_tty.c:948:45: error: passing argument 1 of ‘s3c24xx_serial_rx_irq’ discards ‘const’ qualifier from pointer >> target type [-Werror=discarded-qualifiers] >>   948 |                 ret = s3c24xx_serial_rx_irq(ourport); >>       |                                             ^~~~~~~ >> drivers/tty/serial/samsung_tty.c:856:68: note: expected ‘struct s3c24xx_uart_port *’ but argument is of type ‘const struct >> s3c24xx_uart_port *’ >> >> And so on... > > Looks like I had Werror disabled and therefore just missed them. Sorry for that. > Same on my side. Any idea why CONFIG_WERROR is not enabled by more archs? I see just the two: arch/x86/configs/i386_defconfig:CONFIG_WERROR=y arch/x86/configs/x86_64_defconfig:CONFIG_WERROR=y