From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E89B42E417 for ; Thu, 8 Oct 2026 07:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791444954; cv=none; b=uexsnq0iaTNlQT/IcYI5q7QtFgxtgiW7FU3mahhKoLwRR+KBdeV89K7YGiiFPAmE43AQvqbQoVC0odEPPSMr52hvvHHkrYvIZJdy4dZIFgIx0L1cJVGX8Qo/gT0b/n3D1yYE1SNxpbgD3p+870jCHhVTioDi7dLA2hjq6Mt/bfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791444954; c=relaxed/simple; bh=99wYJp3NJ81UB0rpFIJF2rUNHd+EgUyr1j9RtWZwtoY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ml0VQgWBATx09aOH0xOoYBXPQN3BKhr3gXhLaVArrXeDY97aoWpq7KtkBuX4WPwSaEDu19qSoL1KCQOGYlSBABnOvE1d7dU2mn4ynA2VGUZAJj8d4TbnQD5WF3bl7xhAqmhmkBtxnEYNPpk4rqB7UrZnUJbcNIwpPEJ90g+PMro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XCuej6+K; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IZWPq7TN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XCuej6+K"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IZWPq7TN" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6987K36E3190828 for ; Thu, 8 Oct 2026 07:35:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6E7f87W/XyZ40GqugjOqDeLHSs71iH9JyYqCBHkyOGw=; b=XCuej6+KqJJ7L0Kq 2mw5AHEGCBDCt1Lv5Z2m/TzLxn8Ph6oU/8yqSzzacoiJpijkNCi+hC5uqds3f067 N6XoeoWGMhq+NCUKkX7OkZRTPKkTHI81O79OEIM/6aEEDZUVXBla/9zj+KM5/Qkn Bc9bQfjVyeN55hsCoBghkqg1x9cXoGJLqVS2eSRb6KxHrkHwnmRR56OXEReTzojH LW6e0BiTmFxcXVkFgRUuJyAzYACvOqMxNiiXzKsLYkof3HnYLCi99UYgiglX2x8K uO21LGM2+JQxbK6behqGMq1ehu+3B2wGDYhRREb53omb5k8JmZEnAgdv9Ib3E8v0 vrXo8Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h5xe69rf0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Oct 2026 07:35:49 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3a8ae5154e7so1424040a91.1 for ; Thu, 08 Oct 2026 00:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791444949; x=1792049749; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6E7f87W/XyZ40GqugjOqDeLHSs71iH9JyYqCBHkyOGw=; b=IZWPq7TNYbxXeeEXFaCFUvVY9Cl4nPLT6KiuwsdQB9nLTyw6Bya2KANIPY4l7wQsv3 896f9KVCG4TQ4pG838/ZoqjRzBezipIJq/AXPwyjvVaaFVF4dbs1iPDXhsofxqHpp9bA FsH2569fhpevdgU4Xx3R20GJA+HFYPzpt0Ilp8eNDCEjjXNPeojBeXYPOqwcssLrNR/U S8f/uBqUgn082a/07ImhU3fKebfuq9vTuX5QCs5FqfTTrrw50wHOPaWPoElQLEt0pS+r 8D07WzRml1FNaoaTIYJV4xG2oeoiqqYSWI9j9P3JjCvoSrR+nG3SqGW8ZSpm1kHjCrvH xg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791444949; x=1792049749; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6E7f87W/XyZ40GqugjOqDeLHSs71iH9JyYqCBHkyOGw=; b=uN5n0GOR1wE3OwVUMLkYuYF4KzI/aQlw/7n/j/GFYFykkZPlod9U9nFAq7qGvviByz 7AB8RXh3KxAvi1B5YWRZHP7wU6DWUVIDvudR9T8DSYOKlSEKUnlPBeG4dJFuU7VLEw/1 wDpR+S49OG1GBT4LSH+3qRYH8ywfbcNDN9gm3O+nnTYMuxuh5n6e70YwGJvgx0Kt1KuR C5W+NF6BWjQetXj+uhkgTKOEC4pYVgx3nTj91Q/Dzxs4FolFNvfElmuWR9Vh2d53KKjs P6cOyZ68BZ73dleC+CppoVA4qtVChIC0w6+Xv30bTpPEMoIGXcVXlcAK1X/c3lCNE/eE eroQ== X-Forwarded-Encrypted: i=1; AKwUvBypwkRJPOovACuOFcEXGS4R3ELhSOzwJieYUDgP+D0I+RSpoRPZjkBUnnpXBHJ8mGkKpnLcQRpvAnWMvpI=@vger.kernel.org X-Gm-Message-State: AFq9FYLbG9pikUomPTRR+pQfhQgEgUsXsHJhdA2N4vaMQhsU3IgZnzcM zOFh6KcPN9w0YPESmDDF72lKizGKJJreW9w77p/3M+MfxtMClwLWPYKDz0GtMUZBTvlaOaW5Vcm 2sUIWlei+rptFIpLWt16GxqNYIZbjjaKsR3uja2XIAkXrjayRM+pFeXW87rhJoh4NFOQ= X-Gm-Gg: AYBFou3b0ZvR53/gWF9pKmxfeIQieVuLpe9frOHPjSSN07nuujaH9/uG4wAZdJaZuoz 0xB2xrTt9AyE6n+xR7bElq+slLiSTaO7QVJPbzbWBKMd4AAQxVsHTGBthsF7tDaqbFhSwTbkBNZ trcGID6rcfGcsB4hORHhr32+8WDIfgAIFHuzT0LCR/sZIV5cKCesuxCnj6W8Vwp+lbf1ytI2prk icUnCcbrMrp1ijh0nWg9nzT0gHut2l88kIquUiYWXl8MOH+WhAg/rTXmLiW4W2xdD6qxDwaIUI0 wfM9FpmeW0+rtX7b3UTYoronkBBMl7Z6l2mdhPk+EVF34Ob/8nlyh9SZW40F1j4I91w2vf3s8wE Ao9s6D0Ahw89CkZYs+XQMtlIi0q5uXVEe X-Received: by 2002:a17:90b:288c:b0:3a7:eb0:119f with SMTP id 98e67ed59e1d1-3a8a0f259a5mr3398852a91.43.1791444948600; Thu, 08 Oct 2026 00:35:48 -0700 (PDT) X-Received: by 2002:a17:90b:288c:b0:3a7:eb0:119f with SMTP id 98e67ed59e1d1-3a8a0f259a5mr3398827a91.43.1791444948107; Thu, 08 Oct 2026 00:35:48 -0700 (PDT) Received: from [10.217.219.98] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a9f1bfbafasm3506674a91.11.2026.10.08.00.35.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2026 00:35:47 -0700 (PDT) Message-ID: Date: Thu, 8 Oct 2026 13:05:40 +0530 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] serial: qcom-geni: Use geni_se_set_rate() for source clock configuration To: Praveen Talari , konrad.dybcio@oss.qualcomm.com, Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-0-091697dbeb02@oss.qualcomm.com> <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-5-091697dbeb02@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-5-091697dbeb02@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: YSv1KRhjeZZ6sXvK5TczMylVVnRrhTHZ X-Authority-Analysis: v=2.4 cv=HcWB3SE8 c=1 sm=1 tr=0 ts=6ac747d5 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=l2yqw8MAX8n28sf77-kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: YSv1KRhjeZZ6sXvK5TczMylVVnRrhTHZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA4MDAzMCBTYWx0ZWRfX1ZuMM6lxXGyQ MG8n3UG1ifAbT6qI742qs2jE/g0IK4OfFPBe7C5ZGoUDjPNS6uuh0cl+kimEZbbBSguYPOPfCS4 reGACk5VNkvFucYD70KaPbW7SE78NjsDyOMCKEV0/2nOTNZyaBmIpKympVznpJzZChcLqzZPhHL G4BrLoTkhCxaPL/cAebEmXU4cyzsytK36DeAuru4kzfQZL48kqB6BRYjzdgQACS81X4tad+9WDm NHShIa2cbBWrsocw7Ok92AL0YDJeDoM6h7O2HaIQKIVpoRVaehDegSZ9zXJAWWQtQew3oDz/NiU CE2weyu1vpG/blHt3x8fNLDiHnWWFoYu4oEbO8Mi1eUyMboBfHWndopoHDgcZetHv17evn1gFi/ +hVcpzih4JKnZijkcsIaa/AYK0q/aK+wd2J1vzD5H67DbL+Oxe4Gx4aDHqe8WxJiNZnEdaZDLTM 4TgfYe0ep5x2v65ZEjQ== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA4MDAzMCBTYWx0ZWRfXw1jBCVs1gV6b 46hKzoabwmSAFBlBF3KmCBEoWefVttqxOFTFDopuEvdq3gSPU8TgtXoggxdNVMtbKj+lykKaF9o S5Wbonx53j98O9dxxi/pnMyaz69/hqg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-08_03,2026-10-06_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610080030 On 8/27/2026 11:29 PM, Praveen Talari wrote: [...]> @@ -2039,15 +2041,19 @@ static void qcom_geni_serial_remove(struct platform_device *pdev) > static int __maybe_unused qcom_geni_serial_runtime_suspend(struct device *dev) > { > struct qcom_geni_serial_port *port = dev_get_drvdata(dev); > + int ret; > > - return port->dev_data->power_off ? > - port->dev_data->power_off(&port->se) : 0; > + ret = port->dev_data->power_off ? > + port->dev_data->power_off(&port->se) : 0; > + if (ret) > + return ret; > + > + return geni_se_set_rate(&port->se, 0); Is there any register access happening as part of this geni_se_set_rate() ? i was searching but could not see after seeing set_rate() callback removed.> } > > static int __maybe_unused qcom_geni_serial_runtime_resume(struct device *dev) > { > struct qcom_geni_serial_port *port = dev_get_drvdata(dev); > - struct uart_port *uport = &port->uport; > int ret; > > if (port->dev_data->power_on) { > @@ -2056,8 +2062,8 @@ static int __maybe_unused qcom_geni_serial_runtime_resume(struct device *dev) > return ret; > } > > - if (port->se.has_opp && port->clk_rate) > - return dev_pm_opp_set_rate(uport->dev, port->clk_rate); > + if (port->clk_rate) > + return geni_se_set_rate(&port->se, port->clk_rate); > > return 0; > } [...]