Linux Serial subsystem development
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-serial@vger.kernel.org, "Frank Li" <Frank.Li@kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 03/13] ARM: remove riscpc
Date: Tue, 08 Sep 2026 18:10:47 +0200	[thread overview]
Message-ID: <cfce9a0e-a7b7-409d-b9a4-abb9013469a9@app.fastmail.com> (raw)
In-Reply-To: <20260908155212.810C61F00A3A@smtp.kernel.org>

On Tue, Sep 8, 2026, at 17:52, sashiko-bot@kernel.org wrote:
>
> The Acorn Risc PC platform and its associated drivers, configurations,
> and board files are being removed as the required gcc-8 compiler and
> -march=armv3 option are no longer supported.
>
>>     The main limitation here is the CPU bus that does not allow 16-bit
>>     wide data transfers and hence requires the kernel to be built with the
>>     -march=armv3 compiler option that was discontinued in gcc-9.
>
> [Severity: Low]
> Since this compiler option is the explicitly stated reason for removal in the
> commit message, should we also delete the compiler flag from the tree?
>
> arch/arm/Makefile:
>     arch-$(CONFIG_CPU_32v3)         :=-march=armv3m
>
> Additionally, the config symbol for this architecture version is now
> dead code because its only selector (ARCH_RPC) was removed:
>
> arch/arm/mm/Kconfig:config CPU_32v3
>     config CPU_32v3
>         bool

I decided to remove these two as part of the later StrongARM
removal patch that depends on this one.

>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 81872f61b4317..fdd75b73bf293 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
> [ ... ]
>> -ARM MFM AND FLOPPY DRIVERS
>> -M:	Ian Molton <spyro@f2s.com>
>> -S:	Maintained
>> -F:	arch/arm/include/asm/floppy.h
>> -F:	arch/arm/mach-rpc/floppydma.S
>> -
>
> [Severity: Low]
> Does this leave the floppy header as dead code in the tree? It is removed
> from MAINTAINERS here, but the file itself was left in the tree:
>
> arch/arm/include/asm/floppy.h:
>     #ifndef __ASM_ARM_FLOPPY_H
>     #define __ASM_ARM_FLOPPY_H

This is removed along with ISA bus support later, which also
drops ARCH_MAY_HAVE_PC_FDC, ISA_DMA_API and GENERIC_ISA_DMA.

I could have split up the MAINTAINERS file change, but
it seemed better to do it in one place. Maybe the other
patch would have been better, but then I'd have another
dangling reference to mach-rpc here.

> The Makefile still references it:
>
> arch/arm/Makefile:
>     machine-$(CONFIG_ARCH_RPC)              += rpc

Fixed now, this ended up in the StrongARM patch by
accident.

> The machine type registry still contains it:
>
> arch/arm/tools/mach-types:
>     riscpc                  ARCH_RPC                RISCPC                  1

This is intentional.

> And the CPU selection still evaluates it:
>
> arch/arm/mm/Kconfig:config CPU_SA110
>     select CPU_32v3 if ARCH_RPC
>     select CPU_32v4 if !ARCH_RPC

Again, this is part of the StrongARM removal. I had considered
removing these two lines first, but then I'd have to split up
the CPU_32v3 removal out from that.

     Arnd

  reply	other threads:[~2026-09-08 16:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260908152808.3928630-1-arnd@kernel.org>
2026-09-08 15:27 ` [PATCH 03/13] ARM: remove riscpc Arnd Bergmann
2026-09-08 15:52   ` sashiko-bot
2026-09-08 16:10     ` Arnd Bergmann [this message]
2026-09-09  8:04   ` Thomas Zimmermann
2026-09-09 16:42   ` Bart Van Assche
2026-09-09 20:09     ` Arnd Bergmann
2026-09-11  3:44   ` Ethan Nelson-Moore
2026-09-11  9:07     ` Linus Walleij
2026-09-11 13:25       ` Bart Van Assche
2026-09-11 13:37         ` Linus Walleij
2026-09-13  9:43           ` Arnd Bergmann
2026-09-11 14:38       ` Daniel Palmer
2026-09-11 18:14         ` Linus Walleij
2026-09-12  1:29           ` Daniel Palmer
2026-09-13 18:13             ` Linus Walleij
2026-09-11 18:42     ` Karl Mehltretter
2026-09-12  2:08       ` Ethan Nelson-Moore
2026-09-12  3:59         ` Ethan Nelson-Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfce9a0e-a7b7-409d-b9a4-abb9013469a9@app.fastmail.com \
    --to=arnd@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox