From: Helmut Grohne <h.grohne@intenta.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-serial@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <uwe@kleine-koenig.org>
Subject: [PATCH v3 0/3] serial: xuartps: hardware race condition and cleanup
Date: Mon, 4 Jun 2018 12:21:56 +0200 [thread overview]
Message-ID: <cover.1528106392.git.h.grohne@intenta.de> (raw)
The character transmission in xuartps is racy. If the transmitter is disabled
early, the device is confused and produces a desync. Garbage on the remote end
can be a visible symptom. The second patch in this series tries to reduce that
race condition in accordance with the hardware documentation, but it cannot
remove it entirely. The first and third patches are code cleanup.
Changes since v2:
* Do not attempt to disable the transmitter after a transmission (original
behaviour around 3.14). These patches no longer touch with the transmitter
state at all as requested by Sören Brinkmann.
* Add Acked-by/Reviewed-by tags from Sören Brinkmann after addressing his
remarks.
Earlier patches/discussion at:
https://www.spinics.net/lists/linux-serial/msg23145.html
https://www.spinics.net/lists/linux-serial/msg23156.html
https://www.spinics.net/lists/linux-serial/msg23157.html
Helmut Grohne (3):
serial: xuartps: fix typo in cdns_uart_startup
serial: xuartps: reduce hardware TX race condition
serial: xuartps: remove unnecessary register write
drivers/tty/serial/xilinx_uartps.c | 23 ++++++++---------------
1 file changed, 8 insertions(+), 15 deletions(-)
--
2.11.0
next reply other threads:[~2018-06-04 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 10:21 Helmut Grohne [this message]
2018-06-04 10:22 ` [PATCH v3 1/3] serial: xuartps: fix typo in cdns_uart_startup Helmut Grohne
2018-06-04 10:22 ` [PATCH v3 2/3] serial: xuartps: reduce hardware TX race condition Helmut Grohne
2018-06-04 10:22 ` [PATCH v3 3/3] serial: xuartps: remove unnecessary register write Helmut Grohne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1528106392.git.h.grohne@intenta.de \
--to=h.grohne@intenta.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).