From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
To: linux-serial@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
michal.simek@xilinx.com,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: [PATCH v4 0/2] serial: uartps: Add TACTIVE check
Date: Thu, 19 Mar 2020 15:14:49 +0530 [thread overview]
Message-ID: <cover.1584610774.git.shubhrajyoti.datta@xilinx.com> (raw)
The cdns_uart_tx_empty function is currently checking oly for tx_empty
bit of SR. In some environments, it is leading to a corruption in log
because tx_empty does not gaurantee that all the bytes are transmitted
out of the FIFO. So, add TACTIVE bit in the check.
This patch series does the following:
-Remove unconditional wait for tx_empty inside set_termios function
-Add TACTIVE check in cdns_uart_tx_empty function
Changes in v4:
-Split into two patches as suggested by Johan
Raviteja Narayanam (2):
serial: uartps: Remove unconditional wait inside set_termios
serial: uartps: Add TACTIVE check in cdns_uart_tx_empty function
drivers/tty/serial/xilinx_uartps.c | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
--
2.1.1
next reply other threads:[~2020-03-19 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 9:44 Shubhrajyoti Datta [this message]
2020-03-19 9:44 ` [PATCH v4 1/2] serial: uartps: Remove unconditional wait inside set_termios Shubhrajyoti Datta
2020-03-19 9:44 ` [PATCH v4 2/2] serial: uartps: Add TACTIVE check in cdns_uart_tx_empty function Shubhrajyoti Datta
2020-03-21 10:07 ` Maarten Brock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1584610774.git.shubhrajyoti.datta@xilinx.com \
--to=shubhrajyoti.datta@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).