From: Sreenath Vijayan <sreenath.vijayan@sony.com>
To: john.ogness@linutronix.de, corbet@lwn.net,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
rdunlap@infradead.org, pmladek@suse.com
Cc: rostedt@goodmis.org, senozhatsky@chromium.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, taichi.shimoyashiki@sony.com,
daniel.palmer@sony.com, anandakumar.balasubramaniam@sony.com,
sreenath.vijayan@sony.com
Subject: [PATCH v3 0/2] Add support to dump printk buffer to console via sysrq
Date: Wed, 17 Jan 2024 15:42:18 +0530 [thread overview]
Message-ID: <cover.1705331453.git.sreenath.vijayan@sony.com> (raw)
Hi,
This patch series does two things:
1) Add function to dump the printk buffer messages directly to
consoles. To do this properly, access to printk private items
like PRINTK_MESSAGE_MAX is required. So, the function is
implemented in printk.c as suggested by John Ogness. This
function may sleep as it needs console related locks.
2) Add code in sysrq.c to call the above mentioned function
when sysrq+D is pressed. As the above function may sleep,
it cannot be called from interrupt context. A work is queued
in the system unbound workqueue to call the function when
the key is pressed.
Link to previous discussion:
- https://lore.kernel.org/linux-serial/20231221133953.1507021-1-sreenath.vijayan@sony.com/
Changelog:
V2 -> V3:
- split the implementation into two commits
- added function in printk.c to dump printk buffer to consoles
- added Suggested-by tag
- removed code to dump printk buffer from sysrq.c and called
new function
V1 -> V2:
- modified kernel ring buffer to printk ring buffer
- allocated buf dynamically to prevent stack frame size warnings
- used buf of size 2048 to match PRINTK_MESSAGE_MAX and added comment
-- Sreenath
Sreenath Vijayan (2):
printk: Add function to dump printk buffer directly to consoles
tty/sysrq: Dump printk ring buffer messages via sysrq
Documentation/admin-guide/sysrq.rst | 2 ++
drivers/tty/sysrq.c | 20 ++++++++++++++++-
include/linux/printk.h | 4 ++++
kernel/printk/printk.c | 33 +++++++++++++++++++++++++++++
4 files changed, 58 insertions(+), 1 deletion(-)
--
2.43.0
next reply other threads:[~2024-01-17 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 10:12 Sreenath Vijayan [this message]
2024-01-17 10:12 ` [PATCH v3 1/2] printk: Add function to dump printk buffer directly to consoles Sreenath Vijayan
2024-01-18 9:49 ` John Ogness
2024-01-18 10:14 ` John Ogness
2024-01-20 8:41 ` Sreenath Vijayan
2024-01-17 11:13 ` [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via sysrq Sreenath Vijayan
2024-01-17 10:12 ` Sreenath Vijayan
2024-01-18 10:05 ` John Ogness
2024-01-18 22:56 ` David Laight
2024-01-19 5:47 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1705331453.git.sreenath.vijayan@sony.com \
--to=sreenath.vijayan@sony.com \
--cc=anandakumar.balasubramaniam@sony.com \
--cc=corbet@lwn.net \
--cc=daniel.palmer@sony.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=taichi.shimoyashiki@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).