linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Parker Newman <pnewman@connecttech.com>
Subject: [PATCH v4 0/5] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6
Date: Wed,  2 Oct 2024 11:12:32 -0400	[thread overview]
Message-ID: <cover.1727880931.git.pnewman@connecttech.com> (raw)

From: Parker Newman <pnewman@connecttech.com>

This series of patches replaces the custom 93cx6 EEPROM read functions in
the 8250_exar driver with the eeprom_93cx6 driver. This removes duplicate code
and improves code readability.

In order to use the eeprom_93cx6 driver a quirk needed to be added to add an
extra clock cycle before reading from the EEPROM. This is similar to the
quirk in the eeprom_93xx46 driver.

More details in associated patch and mailing list discussion with
Andy Shevchenko about these changes:
Link: https://lore.kernel.org/linux-serial/Ztr5u2wEt8VF1IdI@black.fi.intel.com/

Changes in v2:
- Dropped patch 3 "misc: eeprom: eeprom_93cx6: Replace printk(KERN_ERR...) with pr_err()".
- Moved Kconfig change into main patch.
- Moved quirk define into struct eeprom_93cx6.
- Moved quirk check function into eeprom_93cx6.h.
- Refactored cti_read_osc_freq() based on feedback.
- Minor commit message formatting fixes.

Changes in v3:
- Rebased to v6.12-rc1.
- Minor commit message rewording.
- Replace CTI_EE_MASK_OSC_FREQ_UPPER/LOWER with a single define in patch 4.
- Add patch 5 from Andy Shevchenko: "serial: 8250_exar: Group CTI EEPROM offsets by device".
Link:https://lore.kernel.org/linux-serial/20240920154430.3323820-1-andriy.shevchenko@linux.intel.com/

Changes in v4:
- Remove trailing newline in patch 1.
- Move CTI_EE_MASK_OSC_FREQ change from patch 4 to patch 3.

Andy Shevchenko (1):
  serial: 8250_exar: Group CTI EEPROM offsets by device

Parker Newman (4):
  misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle
  misc: eeprom: eeprom_93cx6: Switch to BIT() macro
  serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6
  serial: 8250_exar: Remove old exar_ee_read() and other unneeded code

 drivers/misc/eeprom/eeprom_93cx6.c  |  15 +++-
 drivers/tty/serial/8250/8250_exar.c | 130 ++++++++--------------------
 drivers/tty/serial/8250/Kconfig     |   1 +
 include/linux/eeprom_93cx6.h        |  11 +++
 4 files changed, 62 insertions(+), 95 deletions(-)


base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
--
2.46.0


             reply	other threads:[~2024-10-02 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 15:12 Parker Newman [this message]
2024-10-02 15:12 ` [PATCH v4 1/5] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-10-02 15:12 ` [PATCH v4 2/5] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-10-02 15:12 ` [PATCH v4 3/5] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-10-02 15:12 ` [PATCH v4 4/5] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-10-02 15:12 ` [PATCH v4 5/5] serial: 8250_exar: Group CTI EEPROM offsets by device Parker Newman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1727880931.git.pnewman@connecttech.com \
    --to=parker@finest.io \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pnewman@connecttech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).