From: Jiri Slaby <jirislaby@kernel.org>
To: Filip Jensen <dev-Felipe.Jensen@duagon.com>,
gregkh@linuxfoundation.org, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com>
Subject: Re: [PATCH v2] serial: 8250: Fix null ptr deref has_acpi_companion
Date: Tue, 10 Mar 2026 08:17:37 +0100 [thread overview]
Message-ID: <d124f3f9-086b-451c-b484-1d003f992797@kernel.org> (raw)
In-Reply-To: <20260309142836.95514-1-dev-Felipe.Jensen@duagon.com>
The subject is not a proper English though :). Esp. the missing
preposition. And parens.
What about:
serial: 8250: Fix NULL pointer dereference in has_acpi_companion()
?
On 09. 03. 26, 15:28, Filip Jensen wrote:
...
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -756,6 +756,8 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
> if (ret)
> goto err;
> }
> + if (!uart->port.dev)
> + return -EINVAL;
Does this even compile?
thanks,
--
js
suse labs
prev parent reply other threads:[~2026-03-10 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:28 [PATCH v2] serial: 8250: Fix null ptr deref has_acpi_companion Filip Jensen
2026-03-10 7:17 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d124f3f9-086b-451c-b484-1d003f992797@kernel.org \
--to=jirislaby@kernel.org \
--cc=dev-Felipe.Jensen@duagon.com \
--cc=dev-josejavier.rodriguez@duagon.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox