From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
andy.shevchenko@gmail.com, u.kleine-koenig@pengutronix.de,
johan@kernel.org, wander@redhat.com,
etremblay@distech-controls.com, macro@orcam.me.uk,
geert+renesas@glider.be, jk@ozlabs.org,
phil.edworthy@renesas.com, Lukas Wunner <lukas@wunner.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485 support to quad-uart driver.
Date: Mon, 3 Oct 2022 12:20:47 +0300 (EEST) [thread overview]
Message-ID: <d184aa6d-23e-edf6-4cee-f5f4ad6bf90@linux.intel.com> (raw)
In-Reply-To: <20221001061507.3508603-3-kumaravel.thiagarajan@microchip.com>
On Sat, 1 Oct 2022, Kumaravel Thiagarajan wrote:
> pci1xxxx uart supports rs485 mode of operation in the hardware with
> auto-direction control with configurable delay for releasing RTS after
> the transmission. This patch adds support for the rs485 mode.
>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
> Changes in v2:
> - move pci1xxxx_rs485_config to a separate patch with
> pci1xxxx_rs485_supported.
> ---
> drivers/tty/serial/8250/8250_pci1xxxx.c | 57 +++++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_pci1xxxx.c b/drivers/tty/serial/8250/8250_pci1xxxx.c
> index 41a4b94f52b4..999e5a284266 100644
> --- a/drivers/tty/serial/8250/8250_pci1xxxx.c
> +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c
> +
> + if (rs485->delay_rts_after_send) {
> + baud_period_in_ns = ((clock_div >> 8) * 16);
Is this 16 perhaps UART_BIT_SAMPLE_CNT?
--
i.
next prev parent reply other threads:[~2022-10-03 9:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 6:15 [PATCH v2 tty-next 0/3] 8250: microchip: pci1xxxx: Add driver for the pci1xxxx's quad-uart function Kumaravel Thiagarajan
2022-10-01 6:15 ` [PATCH v2 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support Kumaravel Thiagarajan
2022-10-03 9:18 ` Ilpo Järvinen
2022-10-03 9:22 ` Andy Shevchenko
2022-10-05 9:51 ` Kumaravel.Thiagarajan
2022-10-26 10:54 ` Tharunkumar.Pasumarthi
2022-10-31 9:24 ` Tharunkumar.Pasumarthi
2022-10-31 14:37 ` Andy Shevchenko
2022-11-01 15:04 ` Tharunkumar.Pasumarthi
2022-11-01 15:17 ` Andy Shevchenko
2022-11-01 17:54 ` Kumaravel.Thiagarajan
2022-10-03 19:36 ` Christophe JAILLET
2022-10-04 9:46 ` Andy Shevchenko
2022-10-26 11:12 ` Tharunkumar.Pasumarthi
2022-10-26 20:10 ` Christophe JAILLET
2022-10-01 6:15 ` [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485 support to quad-uart driver Kumaravel Thiagarajan
2022-10-03 9:04 ` Ilpo Järvinen
2022-11-01 14:53 ` Tharunkumar.Pasumarthi
2022-11-01 15:25 ` Ilpo Järvinen
2022-11-01 15:35 ` Andy Shevchenko
2022-11-01 15:49 ` Ilpo Järvinen
2022-11-01 18:10 ` Tharunkumar.Pasumarthi
2022-10-03 9:20 ` Ilpo Järvinen [this message]
2022-10-04 17:51 ` Kumaravel.Thiagarajan
2022-10-05 9:43 ` Ilpo Järvinen
2022-10-01 6:15 ` [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power management functions " Kumaravel Thiagarajan
2022-10-03 9:26 ` Andy Shevchenko
2022-10-04 17:20 ` Kumaravel.Thiagarajan
2022-10-26 11:03 ` Tharunkumar.Pasumarthi
2022-10-31 9:41 ` Tharunkumar.Pasumarthi
2022-11-04 10:23 ` Tharunkumar.Pasumarthi
2022-11-04 12:50 ` Andy Shevchenko
2022-10-03 9:51 ` Ilpo Järvinen
2022-10-04 19:01 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d184aa6d-23e-edf6-4cee-f5f4ad6bf90@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=etremblay@distech-controls.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jk@ozlabs.org \
--cc=johan@kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=phil.edworthy@renesas.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).