From: Jiri Slaby <jirislaby@kernel.org>
To: Tapio Reijonen <tapio.reijonen@vaisala.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Shiyan <shc_work@mail.ru>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3] serial: max310x: improve interrupt handling
Date: Mon, 8 Sep 2025 08:57:32 +0200 [thread overview]
Message-ID: <d5d5778e-c498-44c5-952b-e9b2f619f58e@kernel.org> (raw)
In-Reply-To: <20250908-master-max310x-improve-interrupt-handling-v3-1-91985e82ba39@vaisala.com>
On 08. 09. 25, 8:53, Tapio Reijonen wrote:
> When there is a heavy load of receiving characters to all
> four UART's, the warning 'Hardware RX FIFO overrun' is
> sometimes detected.
> The current implementation always service first the highest UART
> until no more interrupt and then service another UART
> (ex: UART3 will be serviced for as long as there are interrupts
> for it, then UART2, etc).
>
> This commit handle all individual interrupt sources before
> reading the global IRQ register again.
>
> This commit has also a nice side-effect of improving the efficiency
> of the driver by reducing the number of reads of the global
> IRQ register.
>
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
Looks/Reads much better now.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
--
js
suse labs
next prev parent reply other threads:[~2025-09-08 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 6:53 [PATCH v3] serial: max310x: improve interrupt handling Tapio Reijonen
2025-09-08 6:57 ` Jiri Slaby [this message]
2025-09-08 13:53 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5d5778e-c498-44c5-952b-e9b2f619f58e@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=tapio.reijonen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox