From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
peter.griffin@linaro.org, krzysztof.kozlowski+dt@linaro.org,
gregkh@linuxfoundation.org
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
conor+dt@kernel.org, andi.shyti@kernel.org,
alim.akhtar@samsung.com, jirislaby@kernel.org,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
andre.draszik@linaro.org, kernel-team@android.com,
willmcvicker@google.com
Subject: Re: [PATCH v3 04/12] tty: serial: samsung: prepare for different IO types
Date: Wed, 10 Jan 2024 09:07:02 +0100 [thread overview]
Message-ID: <d60bb962-9d54-43cd-befd-2ed2fc09db26@linaro.org> (raw)
In-Reply-To: <20240109125814.3691033-5-tudor.ambarus@linaro.org>
On 09/01/2024 13:58, Tudor Ambarus wrote:
> GS101's Connectivity Peripheral blocks (peric0/1 blocks) which
> include the I3C and USI (I2C, SPI, UART) only allow 32-bit
> register accesses. If using 8-bit register accesses, a SError
> Interrupt is raised causing the system unusable.
>
> Instead of specifying the reg-io-width = 4 everywhere, for each node,
> the requirement should be deduced from the compatible.
>
> Prepare the samsung tty driver to allow IO types different than
> UPIO_MEM. ``struct uart_port::iotype`` is an unsigned char where all
> its 8 bits are exposed to uapi. We can't make NULL checks on it to
> verify if it's set, thus always set it from the driver's data.
> Use u8 for the ``iotype`` member of ``struct s3c24xx_uart_info`` to
> emphasize that the iotype is an 8 bit mask.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-10 8:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 12:58 [PATCH v3 00/12] GS101 Oriole: CMU_PERIC0 support and USI updates Tudor Ambarus
2024-01-09 12:58 ` [PATCH v3 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit Tudor Ambarus
2024-01-16 15:50 ` Rob Herring
2024-01-09 12:58 ` [PATCH v3 02/12] dt-bindings: i2c: exynos5: add google,gs101-hsi2c compatible Tudor Ambarus
2024-01-10 8:02 ` Krzysztof Kozlowski
2024-01-09 12:58 ` [PATCH v3 03/12] dt-bindings: serial: samsung: do not allow reg-io-width for gs101 Tudor Ambarus
2024-01-10 8:06 ` Krzysztof Kozlowski
2024-01-10 9:04 ` Tudor Ambarus
2024-01-16 18:11 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 04/12] tty: serial: samsung: prepare for different IO types Tudor Ambarus
2024-01-10 8:07 ` Krzysztof Kozlowski [this message]
2024-01-16 17:50 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 05/12] tty: serial: samsung: set UPIO_MEM32 iotype for gs101 Tudor Ambarus
2024-01-10 8:08 ` Krzysztof Kozlowski
2024-01-16 18:10 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 06/12] tty: serial: samsung: add gs101 earlycon support Tudor Ambarus
2024-01-10 8:08 ` Krzysztof Kozlowski
2024-01-16 17:51 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 07/12] clk: samsung: gs101: add support for cmu_peric0 Tudor Ambarus
2024-01-16 17:42 ` Sam Protsenko
2024-01-17 14:49 ` Tudor Ambarus
2024-01-17 16:11 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 08/12] arm64: dts: exynos: gs101: remove reg-io-width from serial Tudor Ambarus
2024-01-16 17:57 ` Sam Protsenko
2024-01-17 14:59 ` Tudor Ambarus
2024-01-09 12:58 ` [PATCH v3 09/12] arm64: dts: exynos: gs101: enable cmu-peric0 clock controller Tudor Ambarus
2024-01-09 12:58 ` [PATCH v3 10/12] arm64: dts: exynos: gs101: update USI UART to use peric0 clocks Tudor Ambarus
2024-01-16 17:58 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 11/12] arm64: dts: exynos: gs101: define USI8 with I2C configuration Tudor Ambarus
2024-01-16 18:03 ` Sam Protsenko
2024-01-17 15:08 ` Tudor Ambarus
2024-01-17 16:12 ` Sam Protsenko
2024-01-09 12:58 ` [PATCH v3 12/12] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d60bb962-9d54-43cd-befd-2ed2fc09db26@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox