From: Govindraj <govindraj.ti@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Magnus Damm <damm@opensource.se>,
Dan Williams <dan.j.williams@intel.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] Add DMA support for the sh-sci.c serial driver
Date: Fri, 19 Feb 2010 15:42:52 +0530 [thread overview]
Message-ID: <d6a0f7aa1002190212g556341fy8c590f842d746fb0@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1002191053220.4594@axis700.grange>
On Fri, Feb 19, 2010 at 3:26 PM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> On Fri, 19 Feb 2010, Govindraj wrote:
>
>> > + chan = dma_request_channel(mask, filter, param);
>> > + dev_dbg(port->dev, "%s: RX: got channel %p\n", __func__, chan);
>>
>>
>> If dma channel allocation fails how this scenario will be handled,
>> There is an possibility of dma_request_channel returning -EBUSY,
>
> Really? How? I thought it could only return a pointer to a channel or a
> NULL? And if it fails, i.e., chan == NULL, the whole code just stays
> inactive and the driver falls back to normal PIO.
Sorry I missed this part:
if (s->chan_tx) {
if (s->chan_rx) {
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>
---
Regards,
Govindraj.R
next prev parent reply other threads:[~2010-02-19 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:29 [PATCH 0/2] Implement DMA support for the sh-sci.c serial driver Guennadi Liakhovetski
2010-02-18 16:30 ` [PATCH 1/2] sh: extend .device_terminate_all() to record partial transfer Guennadi Liakhovetski
2010-02-18 18:08 ` Paul Mundt
2010-02-18 16:30 ` [PATCH 2/2] Add DMA support for the sh-sci.c serial driver Guennadi Liakhovetski
2010-02-19 9:47 ` Govindraj
2010-02-19 9:56 ` Guennadi Liakhovetski
2010-02-19 10:12 ` Govindraj [this message]
2010-02-18 19:39 ` [PATCH/not-for-mainline] sh7722: enable DMA on all SCIF ports Guennadi Liakhovetski
2010-03-02 3:13 ` [PATCH 0/2] Implement DMA support for the sh-sci.c serial driver Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a0f7aa1002190212g556341fy8c590f842d746fb0@mail.gmail.com \
--to=govindraj.ti@gmail.com \
--cc=damm@opensource.se \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).