Re: [PATCH v2 1/3] printk: Constify name for add_preferred_console()

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Wed, 20 Sep 2023, Petr Mladek wrote:

> On Tue 2023-09-12 14:03:43, Tony Lindgren wrote:
> > While adding a preferred console handling for serial_core for serial port
> > hardware based device addressing, Jiri suggested we constify name for
> > add_preferred_console(). The gets copied anyways. This allows serial core

Hi Tony,

"The gets copied" seems to lack a word (name?).

-- 
 i.


> > to add a preferred console using serial drv->dev_name without copying it.
> > 
> > Note that constifying options causes changes all over the place because of
> > struct console for match().
> > 
> > Cc: John Ogness <john.ogness@linutronix.de>
> > Cc: Petr Mladek <pmladek@suse.com>
> > Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Suggested-by: Jiri Slaby <jirislaby@kernel.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> Makes sense:
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> 
> I assume that this patch would via Greg's tree together with
> the rest of the patchset. Please, tell me if you would prefer to
> queue this via printk tree.
> 
> Best Regards,
> Petr
>