From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1433ACE79C2 for ; Wed, 20 Sep 2023 10:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234346AbjITK42 (ORCPT ); Wed, 20 Sep 2023 06:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234357AbjITK40 (ORCPT ); Wed, 20 Sep 2023 06:56:26 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED19D3; Wed, 20 Sep 2023 03:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695207380; x=1726743380; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=gOPASgTUaTDhCAFxC5YuBhI+3Lyk6hWmJdybfQUtMWg=; b=n/zxCFjVu4pQ+3U8ElMrRdavk5LG7RDjCa1I07IG9OR9CqtSjSEvpWyl 58zgBpYDWk1J5aMGHTUwf8kfK3xINacYpjcn7Egx3lFdiV2U4VxpsMEGu NVb4m8XVwS8qb6qWBdrlGQ6vP2zvzUER8PqeKt/+UJctrpLWp4bv/T7EJ on8z+BVFW0HfbrxO01PwGkBVB9MbwYON2PMmbG3GpPSxGNMHFTJOWtF0r 24mWEhfB3vKQ4oWXx2fL0QpXWiw0BV6Y6AgDQNIG/rdc6aPruaO9zxOXL GAbqSyCzFIWTK3S7ivXJmxXlapoB9Mv96EUD9xEyVghclsZu+6L9CddAQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="360446705" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="360446705" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 03:56:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="723228889" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="723228889" Received: from swegrzyn-mobl.ger.corp.intel.com ([10.252.52.91]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 03:56:14 -0700 Date: Wed, 20 Sep 2023 13:56:12 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Tony Lindgren cc: Petr Mladek , Greg Kroah-Hartman , Jiri Slaby , Sergey Senozhatsky , Steven Rostedt , John Ogness , Andy Shevchenko , Dhruva Gole , =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , LKML , linux-serial Subject: Re: [PATCH v2 1/3] printk: Constify name for add_preferred_console() In-Reply-To: Message-ID: References: <20230912110350.14482-1-tony@atomide.com> <20230912110350.14482-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, 20 Sep 2023, Petr Mladek wrote: > On Tue 2023-09-12 14:03:43, Tony Lindgren wrote: > > While adding a preferred console handling for serial_core for serial port > > hardware based device addressing, Jiri suggested we constify name for > > add_preferred_console(). The gets copied anyways. This allows serial core Hi Tony, "The gets copied" seems to lack a word (name?). -- i. > > to add a preferred console using serial drv->dev_name without copying it. > > > > Note that constifying options causes changes all over the place because of > > struct console for match(). > > > > Cc: John Ogness > > Cc: Petr Mladek > > Cc: Sergey Senozhatsky > > Cc: Steven Rostedt > > Suggested-by: Jiri Slaby > > Signed-off-by: Tony Lindgren > > Makes sense: > > Reviewed-by: Petr Mladek > > I assume that this patch would via Greg's tree together with > the rest of the patchset. Please, tell me if you would prefer to > queue this via printk tree. > > Best Regards, > Petr >