From: Sean Anderson <sean.anderson@seco.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org,
"Greg KH" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Peter Korsgaard" <jacmet@sunsite.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing
Date: Tue, 17 May 2022 10:33:45 -0400 [thread overview]
Message-ID: <d96ccec0-f95e-4f56-a12c-c7c0461a1e7d@seco.com> (raw)
In-Reply-To: <20220517110737.37148-2-ilpo.jarvinen@linux.intel.com>
On 5/17/22 7:07 AM, Ilpo Järvinen wrote:
> BRKINT is within c_iflag rather than c_cflag.
>
> Cc: Sean Anderson <sean.anderson@seco.com>
> Fixes: ea017f5853e9 (tty: serial: uartlite: Prevent changing fixed parameters)
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/uartlite.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 007db67292a2..880e2afbb97b 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -321,7 +321,8 @@ static void ulite_set_termios(struct uart_port *port, struct ktermios *termios,
> struct uartlite_data *pdata = port->private_data;
>
> /* Set termios to what the hardware supports */
> - termios->c_cflag &= ~(BRKINT | CSTOPB | PARENB | PARODD | CSIZE);
> + termios->c_iflag &= ~BRKINT;
> + termios->c_cflag &= ~(CSTOPB | PARENB | PARODD | CSIZE);
> termios->c_cflag |= pdata->cflags & (PARENB | PARODD | CSIZE);
> tty_termios_encode_baud_rate(termios, pdata->baud, pdata->baud);
>
>
Reviewed-by: Sean Anderson <sean.anderson@seco.com>
next prev parent reply other threads:[~2022-05-17 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 11:07 [PATCH 0/9] tty/serial: Termios flag fixes Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 1/9] serial: uartline: Fix BRKINT clearing Ilpo Järvinen
2022-05-17 14:33 ` Sean Anderson [this message]
2022-05-18 12:18 ` Shubhrajyoti Datta
2022-05-18 12:25 ` Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Ilpo Järvinen
2022-05-18 4:16 ` Baruch Siach
2022-05-17 11:07 ` [PATCH 3/9] serial: rda-uart: " Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 4/9] serial: txx9: " Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 5/9] serial: sh-sci: " Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 6/9] serial: sifive: Sanitize CSIZE and c_iflag Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 7/9] serial: st-asc: Sanitize CSIZE and correct PARENB for CS7 Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 8/9] serial: stm32-usart: Correct CSIZE, bits, and parity Ilpo Järvinen
2022-05-17 11:07 ` [PATCH 9/9] pcmcia: synclink_cs: Don't allow CS5-6 Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d96ccec0-f95e-4f56-a12c-c7c0461a1e7d@seco.com \
--to=sean.anderson@seco.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jacmet@sunsite.dk \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).