From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Eric Tremblay" <etremblay@distech-controls.com>,
"Wander Lairson Costa" <wander@redhat.com>,
linux-serial <linux-serial@vger.kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Update Renesas RZ/V2M UART Port type
Date: Mon, 13 Feb 2023 10:37:33 +0200 (EET) [thread overview]
Message-ID: <e02b1d40-70f3-c6e9-f527-c572ad289a@linux.intel.com> (raw)
In-Reply-To: <20230210203439.174913-1-biju.das.jz@bp.renesas.com>
On Fri, 10 Feb 2023, Biju Das wrote:
> RZ/V2M specific register handling for the below restriction mentioned in
> hardware manual
>
> 40.6.1 Point for Caution when Changing the Register Settings:
>
> When changing the settings of the following registers, a PRESETn master
> reset or FIFO reset + SW reset (FCR[2],FCR[1], HCR0[7]) must be input to
> re-initialize them.
>
> Target Registers: FCR, LCR, MCR, DLL, DLM, HCR0.
This information should appear in the changelog of 3/3!
--
i.
> v2->v3:
> * Dropped sclk from priv.
> * Dropped unneeded clk_disable_unprepare from remove().
> * Retained Rb tags from Geert,Andy and Ilpo as the changes are trivial.
> * Replaced of_device_get_match_data()->device_get_match_data().
> * Replaced of_device.h->property.h
> * Dropped struct serial8250_em_hw_info *info from priv and started
> using a local variable info in probe().
> * Retained Rb tag from Ilpo as changes are trivial.
> * Replaced readl/writel()->serial8250_em_serial_in/out() in serial8250_rzv2m_
> reg_update() to avoid duplication of offset trickery.
> * Added support for HCR0 read/write in serial8250_em_{serial_in, serial_out}
> * Added UART_LCR macro support in serial8250_em_serial_in() to read LCR
> * Reordered serial8250_em_{serial_in, serial_out} above serial8250_rzv2m_
> reg_update().
> * Replaced priv->info->serial_out to info->serial_out.
> v1->v2:
> * Dropped patch#1 from previous series
> * Replaced devm_clk_get->devm_clk_get_enabled() and updated clk
> handling in probe().
> * Added Rb tag from Geert.
> * Added patch for updating Renesas RZ/V2M UART type from 16550a->16750
> and also enables 64-bytes fifo.
> * Used .data for taking h/w differences between EMMA mobile and RZ/V2M UART.
> * Added serial_out() to struct serial8250_em_hw_info for the write register
> differences between EMMA mobile and RZ/V2M UART.
> Biju Das (3):
> serial: 8250_em: Use dev_err_probe()
> serial: 8250_em: Update RZ/V2M port type as PORT_16750
> serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
>
> drivers/tty/serial/8250/8250_em.c | 128 ++++++++++++++++++++++++------
> 1 file changed, 102 insertions(+), 26 deletions(-)
>
>
prev parent reply other threads:[~2023-02-13 8:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 20:34 [PATCH v3 0/3] Update Renesas RZ/V2M UART Port type Biju Das
2023-02-10 20:34 ` [PATCH v3 1/3] serial: 8250_em: Use dev_err_probe() Biju Das
2023-02-13 6:23 ` Jiri Slaby
2023-02-14 11:07 ` Biju Das
2023-02-10 20:34 ` [PATCH v3 2/3] serial: 8250_em: Update RZ/V2M port type as PORT_16750 Biju Das
2023-02-12 11:02 ` Andy Shevchenko
2023-02-13 6:26 ` Jiri Slaby
2023-02-13 16:02 ` Biju Das
2023-02-10 20:34 ` [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info Biju Das
2023-02-12 11:09 ` Andy Shevchenko
2023-02-13 8:42 ` Ilpo Järvinen
2023-02-13 8:53 ` Biju Das
2023-02-13 9:10 ` Jiri Slaby
2023-02-13 9:12 ` Jiri Slaby
2023-02-13 9:14 ` Jiri Slaby
2023-02-13 9:31 ` Biju Das
2023-02-13 9:32 ` Jiri Slaby
2023-02-13 11:12 ` Biju Das
2023-02-13 11:31 ` Ilpo Järvinen
2023-02-13 11:40 ` Biju Das
2023-02-13 12:05 ` Ilpo Järvinen
2023-02-13 12:18 ` Biju Das
2023-02-13 16:06 ` Biju Das
2023-02-13 9:57 ` Niklas Söderlund
2023-02-13 10:06 ` Biju Das
2023-02-13 10:29 ` Niklas Söderlund
2023-02-13 13:01 ` Biju Das
2023-02-13 14:09 ` Niklas Söderlund
2023-02-13 14:26 ` Biju Das
2023-02-13 9:22 ` Ilpo Järvinen
2023-02-13 9:28 ` Jiri Slaby
2023-02-13 9:40 ` Ilpo Järvinen
2023-02-13 9:53 ` Jiri Slaby
2023-02-13 9:12 ` Ilpo Järvinen
2023-02-13 8:37 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02b1d40-70f3-c6e9-f527-c572ad289a@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=etremblay@distech-controls.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).