From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 5/5] arch/xtensa, termios: use Date: Thu, 4 Oct 2018 16:08:19 -0700 Message-ID: References: <20181004222953.2229-1-hpa@zytor.com> <20181004222953.2229-6-hpa@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Max Filippov Cc: LKML , Linux-Arch , linux-serial@vger.kernel.org, Chris Zankel , Thomas Gleixner , Greg Kroah-Hartman , pombredanne@nexb.com, kstewart@linuxfoundation.org, linux-xtensa@linux-xtensa.org, Jiri Slaby List-Id: linux-serial@vger.kernel.org On 10/04/18 15:35, Max Filippov wrote: > > Looks good. But why not removing the header entirely and adding > generic-y += termbits.h > to arch/xtensa/include/uapi/asm/Kbuild? > Good idea. Should do that for others that also have the same #include. -hpa