From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: 8250_pericom: Use UART_LCR_DLAB
Date: Mon, 13 Jun 2022 10:28:55 +0200 [thread overview]
Message-ID: <e722f97b-cb18-2d8c-b3f1-38eca21f6a3f@kernel.org> (raw)
In-Reply-To: <20220613075736.12283-2-ilpo.jarvinen@linux.intel.com>
On 13. 06. 22, 9:57, Ilpo Järvinen wrote:
> Use UART_LCR_DLAB instead of literal.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250_pericom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pericom.c b/drivers/tty/serial/8250/8250_pericom.c
> index 95ff10f25d58..b8d5b7714a9d 100644
> --- a/drivers/tty/serial/8250/8250_pericom.c
> +++ b/drivers/tty/serial/8250/8250_pericom.c
> @@ -73,7 +73,7 @@ static void pericom_do_set_divisor(struct uart_port *port, unsigned int baud,
> struct uart_8250_port *up = up_to_u8250p(port);
> int lcr = serial_port_in(port, UART_LCR);
>
> - serial_port_out(port, UART_LCR, lcr | 0x80);
> + serial_port_out(port, UART_LCR, lcr | UART_LCR_DLAB);
> serial_dl_write(up, divisor);
> serial_port_out(port, 2, 16 - scr);
> serial_port_out(port, UART_LCR, lcr);
--
js
suse labs
next prev parent reply other threads:[~2022-06-13 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 7:57 [PATCH 1/2] serial: 8250: Use UART_LCR_WLEN8 instead of literal Ilpo Järvinen
2022-06-13 7:57 ` [PATCH 2/2] serial: 8250_pericom: Use UART_LCR_DLAB Ilpo Järvinen
2022-06-13 8:28 ` Jiri Slaby [this message]
2022-06-13 8:28 ` [PATCH 1/2] serial: 8250: Use UART_LCR_WLEN8 instead of literal Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e722f97b-cb18-2d8c-b3f1-38eca21f6a3f@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox