From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH] tty: serial: lpc32xx_hs: fix missing console boot messages Date: Wed, 23 Jan 2019 00:38:50 +0200 Message-ID: References: <20190115171814.21789-1-alexandre.belloni@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190115171814.21789-1-alexandre.belloni@bootlin.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni , Greg Kroah-Hartman Cc: Roland Stigge , Sylvain Lemieux , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org Hi Alexandre, On 01/15/2019 07:18 PM, Alexandre Belloni wrote: > When probing the HSUART, it is put in loopback mode in order to prevent a > potential issue that may happen on RX (Errata HSUART.1). > > serial_lpc32xx_startup() moves it out of loopback mode but this is too late > to get the kernel boot messages before userspace opens the device. > > Also get out of loopback mode in lpc32xx_hsuart_console_setup(). > > Signed-off-by: Alexandre Belloni the change looks good, thank you. Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir