* [PATCH] serial: 8250: Document termios parameter of serial8250_em485_config()
@ 2023-04-21 9:58 Geert Uytterhoeven
2023-04-24 9:20 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2023-04-21 9:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ilpo Järvinen
Cc: linux-serial, linux-kernel, Geert Uytterhoeven
With W=1:
drivers/tty/serial/8250/8250_port.c:679: warning: Function parameter or member 'termios' not described in 'serial8250_em485_config'
Fix this by documenting the parameter.
Fixes: ae50bb2752836277 ("serial: take termios_rwsem for ->rs485_config() & pass termios as param")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/8250/8250_port.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index dfbc501cf9d1561e..a0fd5ecc07ac66f3 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -668,6 +668,7 @@ EXPORT_SYMBOL_GPL(serial8250_em485_supported);
/**
* serial8250_em485_config() - generic ->rs485_config() callback
* @port: uart port
+ * @termios: termios structure
* @rs485: rs485 settings
*
* Generic callback usable by 8250 uart drivers to activate rs485 settings
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: 8250: Document termios parameter of serial8250_em485_config()
2023-04-21 9:58 [PATCH] serial: 8250: Document termios parameter of serial8250_em485_config() Geert Uytterhoeven
@ 2023-04-24 9:20 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2023-04-24 9:20 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Kroah-Hartman, Ilpo Järvinen
Cc: linux-serial, linux-kernel
On 21. 04. 23, 11:58, Geert Uytterhoeven wrote:
> With W=1:
>
> drivers/tty/serial/8250/8250_port.c:679: warning: Function parameter or member 'termios' not described in 'serial8250_em485_config'
>
> Fix this by documenting the parameter.
>
> Fixes: ae50bb2752836277 ("serial: take termios_rwsem for ->rs485_config() & pass termios as param")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-24 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-21 9:58 [PATCH] serial: 8250: Document termios parameter of serial8250_em485_config() Geert Uytterhoeven
2023-04-24 9:20 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).