From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68824CE7A88 for ; Sat, 23 Sep 2023 09:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbjIWJl4 (ORCPT ); Sat, 23 Sep 2023 05:41:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbjIWJlq (ORCPT ); Sat, 23 Sep 2023 05:41:46 -0400 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0936E198; Sat, 23 Sep 2023 02:41:40 -0700 (PDT) Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTP id jx8VqvAVsEoVsjz8uqH9XJ; Sat, 23 Sep 2023 09:41:40 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id jz8tqcV4D5plfjz8tqPDyX; Sat, 23 Sep 2023 09:41:40 +0000 X-Authority-Analysis: v=2.4 cv=eZguwpIH c=1 sm=1 tr=0 ts=650eb2d4 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=ag1SF4gXAAAA:8 a=pGLkceISAAAA:8 a=8AirrxEcAAAA:8 a=JfrnYn6hAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=ST-jHhOKWsTCqRlWije3:22 a=1CNFftbPRP8L7MoqJWF3:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WqtTqyBOIqIUnEmX5n5kQ73Sw4k1BBS+MWCITPFH/ZE=; b=D5O8Wo3DAcqOpX/c+/na/OI1im GmheqkQaXRkmqWVmY4RZhOa8LpiE+Icn1gHDpdMAWcyv+yHoicjpGJ9GOG0JeQbDV13dhlgQwB5Zu nKag8M8zkhFcb4LBPQbAXVo9NEDgDWtN0/nGBrGmkIhKRL3pWWoxw9KlGTvfiraZrrDv1SVd0n3gK Fa3j9LxyQgAQPTGwzomqctGNhzIXtkQWKOStlm+7yf2vM8+qPnNxs8QNpnHToC2qIqvuewE3v+ktn rmOvsZyibifV4tzmCyOJMsXNqkxtLBlm5hHg6DxrsW09FBfwh8jIWS/a1qVgpotWjUlq53+XAwbq/ tn7l2mTg==; Received: from [94.239.20.48] (port=36680 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjy6h-003f5P-0P; Sat, 23 Sep 2023 03:35:19 -0500 Message-ID: Date: Sat, 23 Sep 2023 10:36:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mxser: Annotate struct mxser_board with __counted_by Content-Language: en-US To: Kees Cook , Jiri Slaby Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922175245.work.196-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922175245.work.196-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjy6h-003f5P-0P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:36680 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBrxcKnogM7KxqPYAbRlb+LY//tNWROT5R48mZihh5H3sDTNVncuIZhpe8xz7gTKkk9Yebc5TaQAvhQWKLOqfcAVfnDtNgChDn2ZxMjjkP7uvNzDvPoP YJg9+ZlsrTsYQTU6PI3VqNLUp/O4g19N8QG+dHP3iHNNkyXionrPoSao49GXkvHW/fMj9CqBARz+07dHSYLa7qWGRP+ufHdo64sUm1N/xwWdwOFOn7SLXi7d 5TpGrf1EO+EI+HOFAU8FVxstaLJ8dsElXhNb4Ij3pPcK1m8suk5bGkB46cQfCm+mc5vUPb9aJ/GKQLWqt9pHnw== Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 9/22/23 11:52, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct mxser_board. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Jiri Slaby > Cc: Greg Kroah-Hartman > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: linux-serial@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/tty/mxser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c > index 10aa4ed38793..6ce7f259968f 100644 > --- a/drivers/tty/mxser.c > +++ b/drivers/tty/mxser.c > @@ -288,7 +288,7 @@ struct mxser_board { > enum mxser_must_hwid must_hwid; > speed_t max_baud; > > - struct mxser_port ports[]; > + struct mxser_port ports[] __counted_by(nports); > }; > > static DECLARE_BITMAP(mxser_boards, MXSER_BOARDS);