From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: "Steffen Dirkwinkel" <lists@steffen.cc>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Mario Limonciello" <mario.limonciello@amd.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
Subject: Re: [PATCH] serial: 8250_dw: Add device HID for AMDI0021 AMD UART controller
Date: Thu, 20 Aug 2026 10:26:11 +0530 [thread overview]
Message-ID: <f22c5687-c379-4fa5-9b32-555ecf5e54f1@amd.com> (raw)
In-Reply-To: <20260813-b4-raven-ridge-uart-v1-1-fae442416ba1@beckhoff.com>
On 14-08-2026 00:07, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>
> This ID is found on AMD V1202B.
> Like the AMDI0022 [1] this one works with the same match and the existing driver.
> Tested with a loopback cable.
>
> [1] commit 3c35d2a960c0 ("serial: 8250_dw: Add device HID for new AMD UART controller")
>
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
Looked at AMD's ACPI reservation table and this looks right to me.
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/tty/serial/8250/8250_dw.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 008bd0552cb7..562be86aa272 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -250,6 +250,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0015", APD_ADDR(wt_i3c_desc) },
> { "AMDI0019", APD_ADDR(wt_i2c_desc) },
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> + { "AMDI0021", APD_ADDR(cz_uart_desc) },
> { "AMDI0022", APD_ADDR(cz_uart_desc) },
> { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> #endif
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 5fba913f3301..214d3e7ae628 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -910,6 +910,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
> { "8086228A", (kernel_ulong_t)&dw8250_dw_apb },
> { "AMD0020", (kernel_ulong_t)&dw8250_dw_apb },
> { "AMDI0020", (kernel_ulong_t)&dw8250_dw_apb },
> + { "AMDI0021", (kernel_ulong_t)&dw8250_dw_apb },
> { "AMDI0022", (kernel_ulong_t)&dw8250_dw_apb },
> { "APMC0D08", (kernel_ulong_t)&dw8250_apmc0d08 },
> { "BRCM2032", (kernel_ulong_t)&dw8250_dw_apb },
>
> ---
> base-commit: 3aa1dcaa4f6f5ae08936491e08bd456f331f2d40
> change-id: 20260813-b4-raven-ridge-uart-62b1ef1fc246
>
> Best regards,
> --
> Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>
prev parent reply other threads:[~2026-08-20 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 18:37 [PATCH] serial: 8250_dw: Add device HID for AMDI0021 AMD UART controller Steffen Dirkwinkel
2026-08-14 9:29 ` Andy Shevchenko
2026-08-20 4:56 ` Shyam Sundar S K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f22c5687-c379-4fa5-9b32-555ecf5e54f1@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lists@steffen.cc \
--cc=mario.limonciello@amd.com \
--cc=rafael@kernel.org \
--cc=s.dirkwinkel@beckhoff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox