From: Manuel Lauss <manuel.lauss@googlemail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Linux-MIPS <linux-mips@linux-mips.org>,
linux-serial@vger.kernel.org,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A
Date: Wed, 28 Oct 2009 20:27:16 +0100 [thread overview]
Message-ID: <f861ec6f0910281227t455a6f5cw9e492a9a1fc1b07e@mail.gmail.com> (raw)
In-Reply-To: <20091028122430.f7670ae2.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
On Wed, Oct 28, 2009 at 8:24 PM, Andrew Morton <akpm@linux-foundation.org>wrote:
> On Wed, 28 Oct 2009 20:09:14 +0100
> Manuel Lauss <manuel.lauss@googlemail.com> wrote:
>
> > UART autodetection breaks on the Au1300 but the IP blocks are
> > identical, at least in the datasheets.
> >
> > Pass uart type on to the 8250 driver via platform data, and move
> > the MSR quirk to another place sind autoconf() is now no longer
> > called on init.
> >
> > Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> > ---
> > Tested on DB1200 and DB1300.
> > The mips parts apply on top of Ralf's mips-queue tree.
> >
> > arch/mips/alchemy/common/platform.c | 4 +++-
> > drivers/serial/8250.c | 13 +++++++------
> > 2 files changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/mips/alchemy/common/platform.c
> b/arch/mips/alchemy/common/platform.c
> > index 195e5b3..3be14b0 100644
> > --- a/arch/mips/alchemy/common/platform.c
> > +++ b/arch/mips/alchemy/common/platform.c
> > @@ -26,7 +26,9 @@
> > .irq = _irq, \
> > .regshift = 2, \
> > .iotype = UPIO_AU, \
> > - .flags = UPF_SKIP_TEST | UPF_IOREMAP \
> > + .flags = UPF_SKIP_TEST | UPF_IOREMAP | \
> > + UPF_FIXED_TYPE, \
> > + .type = PORT_16550A, \
> > }
>
> The kernel which you patched differs from current mainline here.
I know, that's why I added "The mips parts apply on top of Ralf's
mips-queue tree" below
the patch description.
If it makes it easier to apply, I could split this one in a mips and in a
8250 patch?
Thank you!
Manuel Lauss
[-- Attachment #2: Type: text/html, Size: 2464 bytes --]
next prev parent reply other threads:[~2009-10-28 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 19:09 [PATCH 1/2] serial: 8250: reduce Alchemy serial port space size Manuel Lauss
2009-10-28 19:09 ` [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A Manuel Lauss
2009-10-28 19:24 ` Andrew Morton
2009-10-28 19:27 ` Manuel Lauss [this message]
2009-10-28 19:52 ` Andrew Morton
2009-10-28 20:11 ` Manuel Lauss
2009-10-28 22:34 ` Ralf Baechle
2009-10-28 19:36 ` Sergei Shtylyov
2009-10-28 19:55 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f861ec6f0910281227t455a6f5cw9e492a9a1fc1b07e@mail.gmail.com \
--to=manuel.lauss@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).