Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A

[Manuel Lauss <manuel.lauss@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

On Wed, Oct 28, 2009 at 8:36 PM, Sergei Shtylyov <sshtylyov@ru.mvista.com>wrote:

> Hello.
>
>
> Manuel Lauss wrote:
>
>  UART autodetection breaks on the Au1300 but the IP blocks are
>> identical, at least in the datasheets.
>>
>
>  Pass uart type on to the 8250 driver via platform data, and move
>> the MSR quirk to another place sind autoconf() is now no longer
>>
>
>   s/sind autoconf/since autoconfig/
>

Yeah, I suck at writing descriptions. Will fix.


 called on init.
>

 Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> Tested on DB1200 and DB1300.
> The mips parts apply on top of Ralf's mips-queue tree.
>
>  arch/mips/alchemy/common/platform.c |    4 +++-
>  drivers/serial/8250.c               |   13 +++++++------
>  2 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/arch/mips/alchemy/common/platform.c
> b/arch/mips/alchemy/common/platform.c
> index 195e5b3..3be14b0 100644
> --- a/arch/mips/alchemy/common/platform.c
> +++ b/arch/mips/alchemy/common/platform.c
> @@ -26,7 +26,9 @@
>                .irq            = _irq,                         \
>                .regshift       = 2,                            \
>                .iotype         = UPIO_AU,                      \
> -               .flags          = UPF_SKIP_TEST | UPF_IOREMAP   \
> +               .flags          = UPF_SKIP_TEST | UPF_IOREMAP | \
> +                                 UPF_FIXED_TYPE,               \
>

  Good to know this has been implemented.
>

David Daney implemented this recently for his Octeon port, it's a very handy
feature for sure.

Thank you !
      Manuel Lauss

[-- Attachment #2: Type: text/html, Size: 2876 bytes --]